Repository navigation
Fix: the console owner was refused from the host USB panel - #138
Merged
Merged
Conversation
ConsoleCallerCheck counted every account AccountManager stores as a seat account. That includes accounts that were only linked (IsManaged false), and the person at the console is often one of them. On the reference host roelb is linked, so GET /api/host/usb answered 403 NotConsoleUser to the console user themself. The seat-account set is now the accounts MultiSeat created, plus the account of every live seat and of every saved seat preset. A linked account that hosts a seat still counts. The rule is a pure function (SeatSidsFrom) so it can be tested; the new test fails on the old rule. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong. In 0.6.24,
GET /api/host/usbanswered403 NotConsoleUserto the person at the console. The caller check treated every account MultiSeat stores as a seat account. That list also holds accounts that were only linked (IsManagedfalse), and the console owner is often one of them. On the reference host,roelbis linked.What changes. A seat account is now one MultiSeat created, or one that hosts a live seat or has a saved seat preset. A linked account that does host a seat still counts, so a seat user who moves their session to the console with
tsconis still refused. The rule is now a pure function,SeatSidsFrom, so a test can drive it.docs/security-posture.mdsays the same.How this was checked.
🤖 Generated with Claude Code