Repository navigation
fix: a tall image in a doc fits on the screen - #268
Conversation
…ocks stay still until Drop adopts comark-ui's motion layer
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Latest result Pull request merged. Final answersSession Pull request merged. Session Updated the branch with main because main changed package.json, pnpm-lock.yaml after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed package.json, pnpm-lock.yaml after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed package.json, pnpm-lock.yaml after its checks ran; waiting for checks on the new head. Session Updated the branch with main because main changed package.json, pnpm-lock.yaml after its checks ran; waiting for checks on the new head. Hosted checks passed, and 18 focused Markdown tests passed locally. Local Chromium was unavailable, but a delayed-response harness reproduced the P2 Highlight test race. I resolved the thread without a test-only push. The remaining step is to verify the upstream merge and repin Comark UI. Session Pushed 9931278 and resolved the review thread. Markdown images now honor authored width caps and shrink proportionally without typed CSS attr(), while screenshots and chip icons keep their sizing. The Highlight test now waits for submission to finish before checking that strokes clear. Lint, formatting, doctor, and 19 focused tests passed. Playwright’s browser download failed locally, so hosted CI will verify the browser tests. |
There was a problem hiding this comment.
Important
The pinned Comark UI build leaves some ordinary Markdown images taller than the viewport and introduces distortion when zooming images with explicit dimensions on direct Markdown pages.
Approach: Fixing image sizing in the shared Comark UI stylesheet is the right scope, but Drop needs the upstream follow-up as well as the first build.
Reviewed changes — I checked the dependency pins, Drop’s rendered Markdown, and the screenshot controls. All 107 focused tests passed with the PR lockfile.
- Image sizing: The new stylesheet caps and centers plain captioned images without resizing annotated screenshots.
- Renderer configuration:
motion: falsekeeps the new script out of rendered documents, and the Markdown reference audit skipscomark-motion. - Screenshot zoom: The browser test follows the new toolbar wrapper and still verifies copy and gallery navigation.
gpt-6.2-sol(high) | 𝕏
There was a problem hiding this comment.
Important
The new portrait rule fixes the reported zoom distortion, but it also enlarges ordinary link icons and images that authors explicitly sized smaller.
Approach: A local workaround can bridge the upstream pin, but it needs to preserve component sizing and authored widths below the cap.
Reviewed changes — I reviewed the changes in a2b7f05. All 20 targeted tests passed against the PR lockfile; the sizing regression below was verified separately in Chromium.
- Added a local portrait cap. The rule fits nested and explicitly dimensioned portraits while excluding annotated screenshots.
- Added direct-page browser coverage. The test checks emphasis, tables, explicit dimensions, and the zoomed aspect ratio.
- Reformatted the Markdown reference test. The audit still excludes
comark-motion, which remains disabled in the renderer.
gpt-6.2-sol(high) | 𝕏
There was a problem hiding this comment.
Important
The new thumbnail regression test fails in CI and locally: both thumbnails still render at 224×560 instead of 80×200.
Approach: The local width override does not reliably win the cascade, and the proportional sizing it replaces has no fallback on supported Safari. Use one sizing contract: keep authored widths when they fit, and shrink images proportionally when they do not.
Reviewed changes — I reviewed a2b7f05 → 20af92a and ran 20 focused tests against the PR lockfile; 19 passed.
- Moved portrait sizing into Comark’s typeset layer, excluded chip icons, and added a typed
attr()width cap. - Extended browser coverage to include both thumbnail syntaxes and Drop’s fallback favicon. The favicon stayed 14×14 in Chromium.
gpt-6.2-sol(high) | 𝕏
There was a problem hiding this comment.
ℹ️ No P0 or P1 findings remain; the only finding is a test race.
Approach: Passing the authored width from the renderer to CSS fixes both the cascade tie and the dependency on typed attr().
Reviewed changes — I reviewed 20af92a → 9931278. All 43 focused tests passed against the PR lockfile, and the image sizing and zoom checks passed separately in Firefox. WebKit could not launch on this runner.
- Preserved authored widths by rendering a CSS custom property and making the local width cap win over Comark’s default. Both thumbnail forms stayed 80×200, and the larger portrait kept its aspect ratio in zoom.
- Invalidated cached Markdown HTML so existing documents pick up the new width property, and added a test for when the property is emitted.
- Added a composer wait before the highlight test checks that sending clears the strokes.
gpt-6.2-sol(high) | 𝕏

A tall picture in a doc filled the screen: a portrait image took the whole 768px column, so it ran past the bottom of the window as you scrolled. The fix is in comark-ui's typeset (onmax/comark-ui#478), and this moves Drop's comark-ui pins to that PR's build.
::screenshotkeep their size, so their marks don't move.motion: false), so the CSP stays the same and blocks stay still until we decide to adopt it..ca-zoom-tools(comark-ui#472 moved Copy there, beside Hide marks), andcomark-motionjoins the packages the Markdown references skip.Before/after: https://drop.vitehub.dev/d/8b6pvn5aspvd/comark-ui-image-fits-screen
Once #478 merges, the pins should move to its merge commit.
🤖 Generated with Claude Code