Repository navigation
test: verify every public header compiles independently - #2
Open
ayushactiveat wants to merge 1 commit into
Open
ayushactiveat wants to merge 1 commit into
ayushactiveat wants to merge 1 commit into
Conversation
Adds standalone compilation tests for all 7 public JSON headers. Also fixes an ambiguous _json operator definition in json.hpp by re-exporting nlohmann's literal. Fixes vixcpp/vix#555.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds compile tests to ensure each public JSON header includes everything required for independent use.
while writing tests, I also discovered and fixed a bug- (
vix::json::literalsdefined its own_jsonoperator), this caused an ambiguity error when used alongside nlohmann's literals, so updatedjson.hppto properly re-export nlohmann's operator.Fixes #555
🔍 Type of Change
How Has This Been Tested?
verified the changes locally by compiling each of the 7 headers in isolation, and by compiling the
json.hppheader with theVIX_JSON_ENABLE_LITERALS=1macro enabled.