Repository navigation
fix(collectors): use httpx2 in Prometheus collector - #1433
Merged
mergify[bot] merged 1 commit intoOct 22, 2026
Merged
Conversation
swethakommuri
requested review from
dbutenhof,
dfeddema,
jaredoconnell and
sjmonson
as code owners
October 22, 2026 20:37
Contributor
Author
|
@dbutenhof @sjmonson small fix for #1432 (pip installs of main currently fail at import). |
Assisted-by: Claude Signed-off-by: Swetha Kommuri <swethakommuri10@gmail.com>
swethakommuri
force-pushed
the
fix/prometheus-httpx2
branch
from
October 22, 2026 20:44
b8864e2 to
2e8a7c0
Compare
dbutenhof
approved these changes
Oct 22, 2026
Contributor
|
Received a single approval. Will automatically queue for merge once two maintainers approve, all change requests are resolved, and DCO passes. |
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
sjmonson
approved these changes
Oct 22, 2026
Contributor
Merge Queue Status
This pull request spent 35 minutes 35 seconds in the queue, including 35 minutes 11 seconds running CI. Required conditions to merge
|
17 of 27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1432. The Prometheus collector added in #1250 imports
httpx, which is no longer a declared dependency after #1282 moved the codebase tohttpx2. On a pip install ofmain, everyguidellm runfails withModuleNotFoundError: No module named 'httpx'.Related Issues
guidellm runfails on pip install of main —ModuleNotFoundError: No module named 'httpx'(regression from #1250) #1432Details
src/guidellm/collectors/prometheus.py:httpx→httpx2(AsyncClient,AsyncBaseTransport,HTTPError,InvalidURL).tests/unit/collectors/test_prometheus.py:httpx→httpx2(Request,Response,MockTransport,ConnectError).httpx2exports all of these with the same API, andInvalidURLis still a separate exception fromHTTPError, so theexceptclause behaves the same. No functional change.Test Plan
In a venv with
httpxuninstalled (pip show httpx→ not found), WSL2 / Python 3.14.4:python -m pytest tests/unit/collectors/test_prometheus.py: 20 passedguidellm runagainstguidellm mock-serverwith synthetic data (concurrent@10, 20 requests): 20/20 completed, 0 errored. Before this change, the same command failed at import withModuleNotFoundError: No module named 'httpx'.Use of AI
The change was drafted with Claude's help. I applied it and ran the tests above locally myself.
Assisted-by: Claude
Signed-off-by: Swetha Kommuri swethakommuri10@gmail.com