feat(frameworks): enrich cve findings with reference urls - #380
Open
TBX3D wants to merge 2 commits into
Open
Conversation
add References []string to CVEEntry, populated with a deterministic NVD /vuln/detail/<CVE> url per entry. getVulnerabilities and WithVulnerabilities now also return/carry references, surfaced on FrameworkResult.References (json, omitempty) and the builtin module's Extracted["references"]. report-only: finding.Finding and flattenFramework are untouched, so the normalized line sink is unaffected.
lock the bare-major boundary matrix in versionAffected (7 vs 70/17/7000, 4.20 vs 4.2, 4.1 vs 4.10) and assert every knownCVEs entry's references exactly match its own CVE ID's nvd detail url, so a future edit can't silently widen the boundary or misattribute a reference. also pins Finding.Line() staying frozen to "[severity] target module title" for a framework result once cve enrichment (version/cves/references) is populated, guarding against enrichment fields leaking into the line.
github-actions
Bot
added
scan
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage ? 64.88%
=======================================
Files ? 88
Lines ? 7865
Branches ? 0
=======================================
Hits ? 5103
Misses ? 2369
Partials ? 393 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pr summary8 files changed (+190 -16)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a cve finding names the id and the severity but not where to read about it, so triage means pasting the id into a search engine. CVEEntry gains References, filled with the nvd detail url for its own id and surfaced on FrameworkResult.References and the builtin module's Extracted. report-only: finding.Finding and flattenFramework are untouched, so the normalized line sink does not change.