fix(migrate): complete vp migrate for existing Vite+ projects#1821
fix(migrate): complete vp migrate for existing Vite+ projects#1821jong-kyung wants to merge 22 commits into
Conversation
Finish core script, import, and tsconfig type rewrites when vite-plus is already installed but legacy Vite signals remain. Add regression coverage matching the manual migration reproduction with package manager overrides.
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jong-kyung
force-pushed
the
fix/migrate-partial-vite-plus
branch
from
1d85af2 to
822a576
Compare
jong-kyung
force-pushed
the
fix/migrate-partial-vite-plus
branch
from
962e6bc to
e42e2fb
Compare
jong-kyung
changed the title
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
fengmk2
added
test: e2e
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62aaf17b34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Complete existing Vite+ package manager bootstrap checks so partial migrations do not leave unresolved pnpm catalogs, npm override conflicts, or missing pnpm peer rules.
Keep existing Vite+ bootstrap catalog usage limited to paths that also define catalog entries, and cover pnpm/yarn monorepo edge cases.
Limit existing Vite+ direct dependency cleanup to the npm override conflict path so other package managers keep their package specs untouched during bootstrap completion.
|
@fengmk2 I fixed the Codex review feedback. Could you please take another look? 🙇♂️ |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9447d511cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@fengmk2 Could I create a pkg.pr.new build and do more manual testing? |
vite-plus
@voidzero-dev/vite-plus-core
@voidzero-dev/vite-plus-prompts
@voidzero-dev/vite-plus-test
@voidzero-dev/vite-plus-cli-darwin-arm64
@voidzero-dev/vite-plus-cli-darwin-x64
@voidzero-dev/vite-plus-cli-linux-arm64-gnu
@voidzero-dev/vite-plus-cli-linux-arm64-musl
@voidzero-dev/vite-plus-cli-linux-x64-gnu
@voidzero-dev/vite-plus-cli-linux-x64-musl
@voidzero-dev/vite-plus-cli-win32-arm64-msvc
@voidzero-dev/vite-plus-cli-win32-x64-msvc
@voidzero-dev/vite-plus-darwin-arm64
@voidzero-dev/vite-plus-darwin-x64
@voidzero-dev/vite-plus-linux-arm64-gnu
@voidzero-dev/vite-plus-linux-arm64-musl
@voidzero-dev/vite-plus-linux-x64-gnu
@voidzero-dev/vite-plus-linux-x64-musl
@voidzero-dev/vite-plus-win32-arm64-msvc
@voidzero-dev/vite-plus-win32-x64-msvc
commit: |
jong-kyung
force-pushed
the
fix/migrate-partial-vite-plus
branch
from
b722d13 to
595dbae
Compare
|
@fengmk2 I did additional manual testing with the I pushed the follow-up fixes from that testing. Could you please review again when you have time? 🙇♂ |
2 participants
Summary
vite-plusinpackage.jsonas an installation signal, not a migration-complete signal.ESLint/Prettier migration, and active legacy hook migration.
hooks/agent/editor setup unless explicitly requested.
Validation
pnpm -F vite-plus snap-test-global migration-already-vite-pluspnpm -F vite-plus snap-test-global migration-partially-installed-vite-pluspnpm -F vite-plus snap-test-global migration-eslint-lint-staged-mjsvp check --fix packages/cli/src/migration/bin.ts packages/cli/src/migration/migrator.ts packages/cli/src/migration/report.ts packages/cli/src/migration/__tests__/migrator.spec.tsvp test run packages/cli/src/migration/__tests__/migrator.spec.tscloses #1817