Repository navigation
feat(void): add basic auth middleware - #216
Merged
Merged
Conversation
❌ Deploy Preview for staging-void-cloud failed.
|
TheAlexLichter
marked this pull request as ready for review
June 7, 2026 22:02
cpojer
approved these changes
Jun 8, 2026
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
…ation fails (#216) * fix(api): surface the real reason when migration v2 capability negotiation fails When a manifest declares migration protocolVersion 2 but the worker capability probe does not confirm a matching v2 capability, the deploy threw a bare "migration protocol v2 capability negotiation failed" with no reason — and the value-mismatch (skew) path logged nothing at all. Make `probeWorkerMigrationCapabilities` return a discriminated { ok:true, caps } | { ok:false, reason } result that captures the HTTP status plus the worker error body (or CF asset stub / non-JSON / request failure). The caller composes a concrete reason (probe reason, or a field-by-field capability-vs-manifest diff), logs `capability_negotiation_failed`, and throws `...failed: <reason>`, which flows to both the deploy error event and the persisted deployments.error. Diagnostics only — this does not by itself fix a failing deploy. The SPA asset-fallback bug it surfaced is fixed in #250. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: bump framework submodule to void#250 (SPA /__void routing fix) Advances framework de1d581 -> 8fc0db3 (void main), which includes the merged #250: SPA + API apps — and cron/queue-only SPAs with D1 migrations — now route /__void/* to the worker before the SPA asset fallback, so migration protocol v2 capability negotiation reaches the migration handler instead of receiving index.html. Also pulls in the already-merged #247, #249, and v0.10.3 / v0.10.4. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to re-implement Basic authentication via a middleware I noticed that I needed internal knowledge (e.g. that _void/* paths need to be unprotected). This makes it harder for users.
Instead, this PR provides a built-in basic auth helper that considers this already.