Repository navigation
chore(void): remove dead detectSsrPrerender helper - #237
Merged
Brooooooklyn merged 1 commit intoJul 1, 2026
Merged
Conversation
This removes the detectSsrPrerender function and its two module level regexes PRERENDER_RE and GET_PRERENDER_PATHS_RE from packages/void/src/ssr/entry.ts. The function is dead code. detectSsrPrerender is never called anywhere in the monorepo, and ssr/entry.ts is not part of the package exports surface, so it is unreachable from outside the package as well. SSR prerender detection is actually performed by pages/scan.ts, which carries its own PRERENDER_RE and GET_PRERENDER_PATHS_RE and uses them during the page scan. The copy in ssr/entry.ts is a superseded duplicate. There is no behavior change. The function had no callers, the two regexes were used only by that function, and the rest of ssr/entry.ts, including getSsrServerEntryPath and validateSsrEntries, is untouched. The readFileSync import stays because it is still used elsewhere in the file. There are zero references to detectSsrPrerender across packages including tests. The void package typechecks cleanly with tsgo. The net change removes 27 lines.
Brooooooklyn
deleted the
07-01-chore-void-remove-dead-detect-ssr-prerender
branch
July 1, 2026 07:34
cpojer
pushed a commit
that referenced
this pull request
Sep 11, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This removes the detectSsrPrerender function and its two module level regexes PRERENDER_RE and GET_PRERENDER_PATHS_RE from packages/void/src/ssr/entry.ts.
Why
The function is dead code. detectSsrPrerender is never called anywhere in the monorepo, and ssr/entry.ts is not part of the package exports surface, so it is unreachable from outside the package as well. SSR prerender detection is actually performed by pages/scan.ts, which carries its own PRERENDER_RE and GET_PRERENDER_PATHS_RE and uses them during the page scan. The copy in ssr/entry.ts is a superseded duplicate.
Safety
There is no behavior change. The function had no callers, the two regexes were used only by that function, and the rest of ssr/entry.ts, including getSsrServerEntryPath and validateSsrEntries, is untouched. The readFileSync import stays because it is still used elsewhere in the file.
Verification
There are zero references to detectSsrPrerender across packages including tests. The void package typechecks cleanly with tsgo. The net change removes 27 lines.