Repository navigation
feat(env): simplify local and production configuration - #311
Closed
TheAlexLichter wants to merge 3 commits into
Closed
TheAlexLichter wants to merge 3 commits into
TheAlexLichter wants to merge 3 commits into
Conversation
TheAlexLichter
force-pushed
the
feat/simplify-env-secrets
branch
2 times, most recently
from
September 14, 2026 08:27
daee572 to
0842f6f
Compare
TheAlexLichter
force-pushed
the
feat/simplify-env-secrets
branch
from
September 15, 2026 14:30
0842f6f to
95cc099
Compare
TheAlexLichter
marked this pull request as ready for review
September 15, 2026 20:52
Member
|
Thanks, I'm rebasing on main and cherry-picking. |
This was referenced Nov 9, 2026
cpojer
pushed a commit
that referenced
this pull request
Nov 9, 2026
Closes #757 ## Problem `void init` writes `!.env.example` to `.gitignore`, but since #311 Void refuses to start when that file exists. New projects were being told to commit a file that stops dev and build. ## Changes - Remove `!.env.example` from `SCAFFOLD_GITIGNORE_LINES`, so `.env.*` now ignores it. - When `.env.example` is one of the reported files, the dev/build error and `void env check` now add: "env.ts lists the keys this app expects, so .env.example is not needed." Other legacy files such as `.env.local` get the same message as before. - Update the `init` unit test and the `packed-consumer` assertion that expected the file to stay un-ignored, and add coverage for the new message on both paths. Existing projects are unaffected: `void init` only appends missing `.gitignore` lines, so a line already there stays. ## Verification - `vp run check`, format and lint pass. - `vp test run`: passes. The first run had failures from a missing Playwright browser and stale playground builds, plus one port conflict; after installing Chromium and running `vp run build:all`, all 33 of those files passed when rerun. - `.github/scripts/packed-consumer.mjs` was not run locally, so CI will be the first run of that assertion. ## Note Both errors tell users to "follow the env migration guide", but no guide with that name exists in `docs/`. That wording predates this PR and is left unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies environment handling by making
.envthe only local development source and moving production configuration to remote secrets..env.examplegeneration and the.secret()/.public()schema modifiersVITE_*values from build inputs or schema defaults.