Repository navigation
feat(email): align platform email with authoritative gateway design - #331
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f147f09d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5909aaacdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e269fb2a48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6612c363a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…les (#836) Two lint settings in `vite.config.ts` look active but check nothing, and unused code goes unreported in the platform: - `jest/no-focused-tests` is dropped from the effective config because the Jest plugin isn't enabled, so `it.only` and `describe.only` pass `vp lint` and the pre-commit hook. Vitest rejects `.only` in CI, but a local run passes while it skips the file's other tests. - `vp run lint:platform` passes `--type-aware`, but the config enables no type-aware rule, so it reports the same as a plain `vp lint`. An unawaited promise passes. - `no-unused-vars` is off: the `correctness` category is off and the rule was never re-enabled. The SDK packages catch unused locals with TypeScript's `noUnusedLocals`, but the platform packages, `packages/isr`, and `.mjs` scripts have no check, and 17 unused imports, variables, and test helpers had built up in the platform. ## Fix - Use `vitest/no-focused-tests`. The `vitest` plugin is already enabled. - Enable `no-floating-promises`. Plain `vp lint` skips type-aware rules, so only `vp run lint:platform` applies it. The platform has no violations. With a type-aware rule enabled, that task now runs the type checker: about 3 s locally instead of 1 s. - Enable `no-unused-vars` without checking parameters, matching the SDK packages, where TypeScript's `noUnusedLocals` is on and `noUnusedParameters` is off. An options object turns off oxlint's default `^_` ignore pattern, and the code uses `_` names on purpose, so `varsIgnorePattern: '^_'` restates it. Without it, the rule reports 98 of those names. - Leave `platform/packages/api/src/admin/fate/client.generated.ts` out of lint, as `fmt` already does. `@nkzw/fate` imports `mutation` there without using it. - Remove what the rule found. Behavior doesn't change: - `dispatch/src/isr.ts` imported six names that it only re-exports with a separate `export { … } from '@void/isr/core'`. - The proxy's inbound-email test helpers (`streamOf`, `createInboundMessage`, `createCtx`, `routeInboundMessage`) have had no callers since inbound handling moved to the email gateway in #331. The proxy Worker only exports `fetch`. - `routeRelayed` in the email gateway still requires `authoritative.slug`; only an unused copy of it is gone. - The rest are unused imports, a destructured variable, a type alias, and one more test helper. ## Verification - Temporary files confirmed that each rule reports its case: `it.only` and an unused import in an `.mjs` file in `vp lint`, and an unawaited call under `platform/` in `vp run lint:platform` only. - `vp lint`, `vp run lint:platform`, `vp fmt --check`, and `vp run check` pass. - Full suite after a package rebuild: 806 files and 17,064 tests pass; 1 file and 32 tests are skipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Platform email now follows the revised first-release design: a dedicated gateway authenticates zone ingress and bounds tenant dispatch, while PostgreSQL authorizes routing, consent, policy, suspension, quotas, and recorded outcomes.
Validation:
vpr test:allpassed formatting, lint, package/playground builds, platform lint, typechecking, and all 549 test files (10,388 passed, 20 skipped). A separate PostgreSQL 18 run passed all 252 tests across admission, connection lifecycle, operator domain management, operator outcome logs, browser administration, audit, and owner email APIs, including the real transaction-lock regressions.Email remains unreleased. Live Cloudflare acceptance gates must pass before production enablement. Customer-zone relayed forwarding reports
UNSUPPORTED_ACTIONwithout consuming quota because a REST resend does not preserve native forwarding semantics; relayed replies and native forwarding remain supported.