Repository navigation
Fix Cloudflare build handoff, OAuth and interrupted deploy recovery - #345
Closed
TheAlexLichter wants to merge 2 commits into
Closed
TheAlexLichter wants to merge 2 commits into
TheAlexLichter wants to merge 2 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Member
Author
|
Partial local CodeRabbit IDE review of exact head Verdict: invalid as Gate B evidence. The budget helper accepted the committed scope and exact SHA, but the review covered only 15 of 16 changed files; Actionable findings and disposition:
Other returned comments were LGTM. The CLI review pool was unavailable; all CodeRabbit activity used the global budget helper. Review remains incomplete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATTENTION: HEAVILY AI GENERATED, STILL WIP
Cloudflare migrations can fail when Vite emits a nested Worker entry or server-side font files. Browser authentication also uses different credential stores across commands, preventing domain cleanup, and a deploy interrupted after activation can leave a receipt that blocks the next upload.
This change accepts contained nested entries and binary fonts, gives actionable errors for unsupported artifacts, uses Cloudflare's public auth SDK with one encrypted profile throughout the compatibility transport, and performs final-domain deletion/restoration through that authenticated transport. Retries recognize the verified last candidate as the live parent and start a new receipt chain. Existing target, receipt, uploader, traffic and secret-inheritance checks remain in place; DNS ownership conflicts are not overridden.
Regression coverage exercises real cf prebuilt dry runs, encrypted OAuth and named profiles, account-pinned domain/cron cleanup, failed-domain restoration, and interrupted activation recovery. The public docs describe final-domain browser authentication and restoration outcomes. Based on 0.21.5, including upstream's active-secret pinning changes.
Validation: formatting, lint, builds, artifact checks, platform lint, and typechecking pass. The full SDK/platform run passes 11,050 tests with two timestamp assertions failing; clean upstream 0.21.5 reproduces exactly those two failures. All four npm full packed consumers pass. The pnpm matrix fails on the default age policy for newly published dependencies; with a process-local age override, all four fail later when init loads a config from a package path removed by its own install. The latter also reproduces on clean upstream 0.21.5. These baseline issues remain visible; this PR has not been published as a package. Final-head verification includes the HTTP error-reporting follow-up and its two passing transport tests. This adds 18 passing regressions compared with clean upstream. The partial CodeRabbit review and disposition are posted in the PR; excluded lockfile coverage and the later commit mean Gate B is incomplete.