Repository navigation
fix(platform): accept sandbox controllers without echoed binding props - #349
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Brooooooklyn
force-pushed
the
fix/sandbox-controller-settings-props
branch
from
September 30, 2026 12:02
5183a22 to
ee9395c
Compare
Brooooooklyn
enabled auto-merge (squash)
September 30, 2026 12:02
Brooooooklyn
force-pushed
the
fix/sandbox-controller-settings-props
branch
8 times, most recently
from
September 30, 2026 14:13
43c6bbe to
1d37ebe
Compare
Cloudflare applies service binding `props` at runtime but omits them from the script `/settings` response. The controller assertion required them, so every managed Sandbox deploy failed on its own freshly created controller. Keep the service and entrypoint checks; the plain-text identity bindings from the same upload still bind the deployment. The Cloudflare mock now returns the real `/settings` shape. Fixes #344 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Brooooooklyn
force-pushed
the
fix/sandbox-controller-settings-props
branch
from
September 30, 2026 14:38
1d37ebe to
244d079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #344
Problem
Every managed Sandbox deploy failed at
worker_uploadwith:provisionSandboxControlleruploads thevoid-sb-*controller with aservicebinding that carriesprops, then reads/settingsback and required the sameprops. Cloudflare appliespropsat runtime but never returns them:(Checked against the live Cloudflare API with throwaway scripts.) So the check rejected even a freshly created controller. The integration mock echoed uploaded bindings verbatim, which hid this.
Fix
propscomparison inassertConfiguration. Keep theserviceandentrypointchecks. The plain-text identity bindings (__VOID_SANDBOX_OWNER,__VOID_USER_ID,__PROJECT_ID,__VOID_PROJECT_SLUG,__VOID_DEPLOYMENT_ID) come from the same upload and are still checked;SandboxControlstill verifies each admission against the database./settingsshape (noprops, addsenvironment). With the old assertion, the sandbox integration suite fails with the production error.Also confirmed live:
/settingsreturnsnamespace_idfor the controller's Durable Object binding, including withcontainers, so the next check in this path holds.Verification
vp test run --project platform-api-integration platform/packages/api/test/integration/api-sandbox.test.ts: 15/15vp test run --project "platform-*": all pass@voidcloud/apitypecheck: pass🤖 Generated with Claude Code