Skip to content

fix(platform): accept sandbox controllers without echoed binding props - #349

Merged
Brooooooklyn merged 1 commit into
mainfrom
fix/sandbox-controller-settings-props
Sep 30, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
fix/sandbox-controller-settings-props

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Fixes #344

Problem

Every managed Sandbox deploy failed at worker_upload with:

Sandbox controller authority binding differs from this deployment.

provisionSandboxController uploads the void-sb-* controller with a service binding that carries props, then reads /settings back and required the same props. Cloudflare applies props at runtime but never returns them:

PUT  script, service binding + props  → 200, target entrypoint sees ctx.props ✓
GET  /settings                         → { entrypoint, environment, name, service, type }  (no props)
GET  /bindings, /versions/{id}         → same, no props

(Checked against the live Cloudflare API with throwaway scripts.) So the check rejected even a freshly created controller. The integration mock echoed uploaded bindings verbatim, which hid this.

Fix

  • Drop the props comparison in assertConfiguration. Keep the service and entrypoint checks. The plain-text identity bindings (__VOID_SANDBOX_OWNER, __VOID_USER_ID, __PROJECT_ID, __VOID_PROJECT_SLUG, __VOID_DEPLOYMENT_ID) come from the same upload and are still checked; SandboxControl still verifies each admission against the database.
  • The Cloudflare mock now returns the real /settings shape (no props, adds environment). With the old assertion, the sandbox integration suite fails with the production error.

Also confirmed live: /settings returns namespace_id for the controller's Durable Object binding, including with containers, so the next check in this path holds.

Verification

  • vp test run --project platform-api-integration platform/packages/api/test/integration/api-sandbox.test.ts: 15/15
  • vp test run --project "platform-*": all pass
  • @voidcloud/api typecheck: pass

🤖 Generated with Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T14:43:45.037607Z 244d079 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-sandbox-controller-settings-props-void-cloud.voidzero-docs.workers.dev (commit 43c6bbe)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://cb5ebb6a-void-cloud.voidzero-docs.workers.dev 43c6bbe 2026-09-30T13:58:22.503Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d4bb8413-void-cloud.voidzero-docs.workers.dev c755fac 2026-09-30T13:49:46.352Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://4a4d699a-void-cloud.voidzero-docs.workers.dev 52a3eb7 2026-09-30T13:30:40.424Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://8ff5db76-void-cloud.voidzero-docs.workers.dev 7bf6267 2026-09-30T13:27:19.525Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://892a2399-void-cloud.voidzero-docs.workers.dev e6f9562 2026-09-30T13:34:25.642Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://ac99b04e-void-cloud.voidzero-docs.workers.dev a194f3a 2026-09-30T13:26:45.096Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://f7c1908b-void-cloud.voidzero-docs.workers.dev 0700025 2026-09-30T13:04:13.486Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://eaf4eb5d-void-cloud.voidzero-docs.workers.dev ee9395c 2026-09-30T12:03:15.021Z Visit the dashboard ↗
  • Build: Failed ❌

View logs ↗
5183a22 2026-09-30T11:58:59.106Z View logs ↗

@Brooooooklyn
Brooooooklyn force-pushed the fix/sandbox-controller-settings-props branch from 5183a22 to ee9395c Compare September 30, 2026 12:02
@Brooooooklyn
Brooooooklyn enabled auto-merge (squash) September 30, 2026 12:02
@Brooooooklyn
Brooooooklyn force-pushed the fix/sandbox-controller-settings-props branch 8 times, most recently from 43c6bbe to 1d37ebe Compare September 30, 2026 14:13
Cloudflare applies service binding `props` at runtime but omits them
from the script `/settings` response. The controller assertion required
them, so every managed Sandbox deploy failed on its own freshly created
controller. Keep the service and entrypoint checks; the plain-text
identity bindings from the same upload still bind the deployment.

The Cloudflare mock now returns the real `/settings` shape.

Fixes #344

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Brooooooklyn
Brooooooklyn force-pushed the fix/sandbox-controller-settings-props branch from 1d37ebe to 244d079 Compare September 30, 2026 14:38
@Brooooooklyn
Brooooooklyn merged commit d053e5f into main Sep 30, 2026
16 of 18 checks passed
@Brooooooklyn
Brooooooklyn deleted the fix/sandbox-controller-settings-props branch September 30, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy with sandbox manifest fails: controller authority binding differs (void-sb-* worker fails own assertConfiguration)

1 participant