Skip to content

fix(platform): migrate GitHub org data off owner pointers - #355

Merged
Brooooooklyn merged 2 commits into
mainfrom
fix/org-join-legacy-owner
Oct 1, 2026
Merged

Brooooooklyn merged 2 commits into
mainfrom
fix/org-join-legacy-owner

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Problem

Since the GitHub org authorization change reached prod (09-22), two kinds of old rows break org users:

github_installations (Organization)  user_id = first installer  (old code wrote it)
  join/complete: "caller already owns it" → skip → no membership
  listing:       org user_id is ignored   → needs a membership
  → the original installer never sees their org install in `void github connect`

github_connections (Organization)    authorized_by_user_id = NULL  (migration 0036 had no backfill)
  → every build / OIDC exchange fails: "reconnect the organization repository"

The installer cannot reconnect, because they cannot join. Prod: 7 of 10 org installs have an owner pointer; 16 org connections have no authorizer.

Fix

Fix the data and delete the code that only existed for the old shapes.

Migration 0052 (data only):

Step Rows (prod)
user_id = NULL on Organization installs 7
backfill authorized_by_user_id on personal connections where install owner = project owner (exactly the rows that pass today) 18
cancel active builds of connections about to be deleted (same order as disconnect) 0
delete connections with no authorizer or no repository_id (nobody proved access; all already fail closed) 16
delete memberships on personal installs 0

Removed code paths: join owner skip, org owner-pointer clearing on member_removed, the unproven personal authority arm, in-place org reauthorization (a second org connect now returns 409 like personal), requires_reconnect (API + CLI status row), and optional iat / connectionId / repository_id / OIDC owner-claim fallbacks.

Kept: runtime authority checks (scheduler, build manager, OIDC) and the CLI's older-platform branches.

compatibility.json: adds 0.21.9 (all 0.21.x code already ignores org user_id for authority and never writes the deleted shapes).

User impact

Owners of the 16 deleted org connections run void github connect again (their deploys already fail today). Org installers who were hidden by the join skip can now void github join.

Follow-up (after this is in prod)

NOT NULL on authorized_by_user_id and repository_id, a CHECK that Organization installs have no user_id, change the authorizer FK from ON DELETE SET NULL, and prune old compatibility pairs. These wait one release because schema-compat CI runs the prod branch's tests, which still seed the old shapes.

Verification

  • vp run check ✓, vp lint ✓, vp fmt --check ✓
  • vp test run: 593 files, 11149 passed
  • migration test seeds every old shape plus active / finished builds on removed and kept projects
  • 0052 applied on a fresh DB through the drizzle migrator

🤖 Generated with Claude Code

Organization installs have no owner and every connection must record who
proved repository access, but rows written before that model kept an org
owner pointer or no authorizer. The join flow still read the pointer, so
the original installer of an org install could never see it in
`void github connect`, and org connections without an authorizer failed
every deploy with no way to reconnect them.

Migration 0052 moves the data to the current model and the code drops the
branches that only existed for the old shapes:

- clear user_id on Organization installs
- backfill authorized_by_user_id for personal connections whose install
  owner is the project owner
- cancel active builds of, then delete, connections with no authorizer or
  no repository id (nobody proved access to them)
- delete memberships on personal installs

Removed: the join owner skip, org owner-pointer clearing, the unproven
personal authority arm, in-place org reauthorization, requires_reconnect,
and optional iat / connectionId / repository_id / OIDC owner fallbacks.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T05:24:29.236604Z a348b04 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-org-join-legacy-owner-void-cloud.voidzero-docs.workers.dev (commit a348b04)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://3fee31cd-void-cloud.voidzero-docs.workers.dev a348b04 2026-10-01T05:21:11.543Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://300e34d8-void-cloud.voidzero-docs.workers.dev cb5ba3c 2026-10-01T05:05:49.018Z Visit the dashboard ↗

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb5ba3c515

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The GitHub connection authority migration now cancels active builds and deletes every connection whose authorizer is not the project owner or a project admin, matching the runtime authority check. Older data with a stale authorizer no longer keeps a connection that can never build and blocks a new connect.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a348b04bcc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Brooooooklyn
Brooooooklyn merged commit 4199ba2 into main Oct 1, 2026
18 of 19 checks passed
@Brooooooklyn
Brooooooklyn deleted the fix/org-join-legacy-owner branch October 1, 2026 06:43
Brooooooklyn added a commit that referenced this pull request Oct 4, 2026
…rm 0.23.0 in the CLI (#356)

## Why

#355 (released in v0.22.0) moved the data to the current GitHub
authority model and removed the code for the old shapes. This PR makes
the schema enforce that model, so those shapes can no longer come back.

## Migration 0057

```
cleanup (idempotent; 0 rows expected after 0052)
  one statement: DELETE connections without owner/admin authority RETURNING project_id
                 → cancel those projects' active builds   (same lock order as runtime: connection → builds)
  UPDATE github_installations SET user_id = NULL WHERE account_type = 'Organization'
DDL
  github_connections.repository_id          NOT NULL
  github_connections.authorized_by_user_id  NOT NULL
  authorized_by_user_id FK                  ON DELETE SET NULL → NO ACTION
```

**FK: NO ACTION.** `deleteUser` is the only code that deletes a `users`
row, and it removes every connection the user authorized first
(cancelling builds). With CASCADE, a connection that escaped that
cleanup would disappear without cancelling its builds. With NO ACTION,
that case fails loudly.

## Code

- **Upsert fix:** `upsertGitHubInstallation` clears `user_id` when the
incoming account type is `Organization` (a personal account converted
into an organization).
- **Removed:** runtime null handling that the NOT NULL columns make
dead: nullable `repositoryId` types, the null-repository fail-closed
branches, and the `?? 'unknown'` authorizer fallback.

## Removed compatibility paths

Each path was checked against current code and every rollback target
(0.20.3 – 0.24.0). No writer uses it.

| Path | Change |
|---|---|
| Membership without a GitHub account id | Join codes and memberships
take a `string` account id. `/github/join/complete` rejects a join code
without one. The column stays nullable: the schema-compat job runs the
deployed runtime's tests, and they still insert rows without it. |
| Singular `buildId` in webhook responses | Removed. Responses return
`buildIds`. The ingress relay passes the body through, and GitHub
ignores it. |
| `run_attempt` null handling | The OIDC exchange returns 401 without
`run_attempt`. A `workflow_run` event without it is ignored. The build
column stays nullable, because container builds have no attempt. |
| Deploy tokens without `build` or `credential` | The auth middleware
returns 401. Every build token is minted with `build` and lives at most
65 minutes. CI credential tokens carry `credential`. |
| Queued build without a branch | The scheduler cancels it ("github
connection config changed") and does not fall back to the connection
branch. |

Kept on purpose: the claim-time instance-type fill-in. Without it, one
queued row without an instance type would block the build queue.

## CLI minimum platform version

`feat(void)`: the `void` CLI requires platform 0.23.0 or newer
(`MIN_PLATFORM_VERSION` in `packages/void/src/cli/client.ts`).

```
PlatformClient.request()
  └─ once per process and platform URL: GET /.well-known/void-platform (no account token)
       0.23.0 or newer          → pass
       older than 0.23.0        → stop: "… runs version X, but this CLI requires 0.23.0 or later.
                                   Ask its administrator to upgrade the platform runtime with `void platform upgrade`."
       404 (HTML or JSON)       → stop: the platform predates discovery, so it predates the minimum
       "hosted"                 → pass (a hosted deploy that does not set PLATFORM_VERSION yet)
       other version string     → pass (custom or development build)
       network error, timeout,
       503, Access login page,
       invalid document         → the real request runs and reports its own error
  every outcome is kept for the rest of the process, so polling commands probe once
```

- Hosted API and email gateway deploys now set `PLATFORM_VERSION` from
`packages/platform/package.json`
(`platform/scripts/platform-version.ts`). Release order: deploy hosted
prod, then publish npm (`platform/meta/operations.md`).
- Login and `void connect` skip the check, so users can still sign in to
an older platform. Platform upgrade, status, rollback, domain
activation, and operator commands do not use `PlatformClient`, so they
keep working on older runtimes.
- Removed CLI fallbacks for older platforms:
- deploy streams without an `x-void-deployment-id` receipt (server
change a98803f, in 0.23.0). A 200 deploy response without a receipt now
fails with "Platform returned no deployment receipt."
- user build-log pages without `logsComplete` (server change c37e951,
in 0.23.0). `null` still means "cannot prove completion".
  - workflow path echo checks
  - optional `cname_target` on domain status
  - missing `id` on `whoami`
  - missing project `role` on read paths
- "upgrade the platform runtime" on a 404 from project choices and
resolve
  - unused `repository_id` on GitHub connections
- Checked at v0.23.0 and kept:
- Heartbeats have no `seq`, and heartbeat `status` plus the observation
page `heartbeat` came in 21d4ec4, after 0.23.0. These stay optional.
`recoveryAt` is sent only while a lease exists.
- Operator build-log `logsComplete === undefined`: operator commands
skip the version check, and servers before 0.20.0 omit it.
- `void platform domain` handling of a 404 from runtimes before 0.22.0
(a management command).
- 0.23.0 runtimes always answer a CLI deploy with the receipt: the
packaged runtime has `deploymentExecution: 1`, so the installer binds
`DEPLOYMENTS_QUEUE`, and every hosted wrangler environment binds it too.
The inline stream without a receipt runs only when that binding is
missing.
- Docs: the self-hosting guide, platform maintenance, and the Sandboxes
guide name the minimum.

## Compatibility edges

| Version | Schema | Edge | Reason |
|---|---|---|---|
| 0.10.14 (6) | – | removed | inserts connections without
`authorized_by_user_id` |
| 0.20.1 | – | removed | writes a NULL authorizer for personal installs
|
| 0.20.3 – 0.21.9 | 089431e2, 408364e6, 9a9ae667, ac70deb5 | kept |
always writes both fields; `deleteUser` cleans connections first |
| 0.22.0 (2) | bb024ebd (0053), bef2a1cf (0055) | kept | same |
| 0.23.0 | 3e3458ba (0056) | **added** | same code paths; without it a
0.23.0 install cannot upgrade to a runtime with 0057 |
| 0.24.0 | 3e3458ba (0056) | **added** | same, and no writer changed
from 0.23.0 |

The digests match the runtimes published to npm (`@void/platform` 0.23.0
and 0.24.0). Self-hosted installs on 0.10.14 or 0.20.1 must upgrade
through a release from 0.20.3 to 0.24.0 first.

## Not in this PR

- A CHECK (`Organization` ⇒ `user_id IS NULL`) waits for a later
release. The rollback targets 0.20.3–0.24.0 still run the old upsert,
which keeps `user_id` on a User→Organization conversion and would
violate the CHECK. It can land once every rollback target contains the
upsert fix above.
- `github_installation_members.github_account_id NOT NULL` waits for the
same reason: the deployed runtime's tests still insert rows without it.

## Test deadlock on PostgreSQL

`test(platform)`: both failed v0.24.0 publish runs stopped in
`platform-ci / schema-compat` on `deploy-direct-r2.test.ts` with `40P01
deadlock detected`.

```
test A: POST /deploy (JSON) → checks status only, never reads the NDJSON body
        the deploy keeps running detached (routes/deploy.ts `void pipeline`)
          tx: SELECT projects FOR UPDATE  → UPDATE deployments
test B: beforeEach clearTables (one transaction)
          delete from deployments          → delete from projects
opposite lock order → 40P01 (PGlite has one connection, so only real Postgres shows it)
```

- The integration setup now reads every unread deploy NDJSON body after
each test, so the deploy finishes before the next cleanup. Receipt
streams only poll, so they are cancelled instead.
- A single `TRUNCATE` still deadlocked in a local reproduction, and
changing only the cleanup would still let the leaked deploy write into
the next test.
- New Postgres-only regression `unread-deploy-cleanup.test.ts` holds a
deploy at its project lock and leaves it unread. Before the fix it
failed 3/3 with `40P01`; after, it passed 3/3. It is skipped on PGlite.
- Running the deployed (84d60bc) copy of `deploy-direct-r2.test.ts` on
Postgres: 4/6 runs deadlock with the old setup, 0/8 with the new one.
- Main's runner already avoids this in schema-compat: d5ddae4 drains
the stream in main's copy of the test, and the runner patches the older
deployed copy by checksum. That is why v0.24.0+retry.2 published. This
change fixes the harness itself, so a test that forgets to read the body
cannot deadlock.

## Also

`test(platform)`: the Sandbox drain audit test read `operator_events`
without `ORDER BY`. Each audit row is inserted and then updated, so on a
reused Postgres table its physical position can change. The test now
reads by creation time. Production already sorts these rows.

## Verification

- `vp run check` ✓, `vp lint` ✓, `vp run lint:platform` ✓, `vp fmt
--check` ✓
- `vp test run`: 678 files (1 skipped: the Postgres-only regression on
PGlite), 12732 passed, 27 skipped.
- `vp run test --base origin/main`: selected all 678 files; 12732
passed, 27 skipped.
- Schema-compat simulated locally with main's runner (one database copy
per file): baseline = current Prod deployment `9ef5d5b5` (platform
0.24.0), migrated + seeded, then this branch's migrations + fixture
verify, then the baseline's API integration tests on Postgres in UTC:
99/99 files, 2344 tests passed.
- Both platform API integration projects together on one real Postgres
database: 3 runs, 0 deadlocks (2347 tests per run). The few failures
there (`api-health` "relation already exists",
`platform-email-bootstrap:125`) also happen on plain main in the same
setup; plain main also hit the `operator-operations` Sandbox drain read
that the second commit fixes.
- Built CLI, no saved login: hosted `api.void.cloud` passes the check
(then 401 for a bogus token); a fake 0.22.0 platform stops with the
minimum-version error and gets no API call; a fake 0.23.0 platform
passes.
- Migration test seeds stray rows (including a NULL authorizer from a
real user delete under SET NULL) and checks the cleanup and the
constraints. The installer test upgrades 0.23.0 and 0.24.0 databases
through 0057 and refuses 0.22.0 at that schema.
- Fresh DB through the drizzle migrator: 51 migrations, both columns NOT
NULL, FK NO ACTION. A second `db:generate` reports no changes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant