Repository navigation
fix: finish or correct Void features that were advertised but unfinished - #433
Merged
Merged
Conversation
Docs, help, types and error messages promised behavior that the code did not have. Each case now either works, or the promise matches the code: - Markdown code-block copy buttons copy the code. - The cognito auth provider reads its domain, region and user pool ID. - Hosted `void db execute --remote --file` runs the file on the configured D1 binding. - `void gen model` writes the database types it promises. - Remote R2 keeps object metadata and list options, and refuses what it cannot honor instead of returning wrong data. - Help, the CLI and API references, and guides describe what Void does. - Public options and exports that never worked are deprecated, not removed, because Void is on 1.x. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-unfinished-features-void-cloud.voidzero-docs.workers.dev (commit 6fead32)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fead32656
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cpojer
pushed a commit
that referenced
this pull request
Nov 9, 2026
Void reads queue consumer options from the source without running it,
and only understands `export const name = <literal>`. Every other way of
exporting the same name is skipped without a message. A queue that
shares its options through a module builds and deploys with Cloudflare's
defaults:
```ts
// queues/_options.ts
export const maxRetries = 0;
export const retryDelay = 30;
```
```ts
// queues/emails.ts
import { defineQueue } from 'void';
export { maxRetries, retryDelay } from './_options';
export default defineQueue(async (batch) => {
// ...
});
```
The consumer gets `maxRetries` 3 and `retryDelay` 0, so a failing
message is retried three times without delay instead of being dropped.
The same happens with export lists (`export { maxRetries }`), `let` and
`var`, destructuring, and `export * from`. The queues guide only says
"Export named constants".
Page settings are read the same way: `revalidate`, `prerender` and `ssr`
in a page's `.server.ts`, and `layout` in a page component. There, a
computed value is skipped as well: with `export const revalidate = 60 *
60`, the page falls back to `routing.revalidate`.
## Fix
The shared reader in `shared/static-exports.ts` now also reports the
names a scanner asks about that are exported in a form whose value it
cannot read, and whether the module uses `export * from`. Each scanner
decides what to do with them:
- Queue options in another form fail the build, as computed values
already did:
```
queue: maxRetries in 'emails.ts' must be declared in the queue file as
`export const maxRetries = <integer>`. Re-exported options and other
export forms are not read.
```
- Page settings that cannot be read are still ignored, but print a
warning once per file. A hard error would break builds that ship them
today, which is also why #433 made layout paths a warning.
- `export * from` in a queue file, a page's `.server.ts` or a page
component prints a warning, since Void cannot tell which names it brings
in. The check that decides whether to parse a file skips whitespace and
comments, so `export /* shared */ * from` counts too. A queue file that
declares all four options, or a page that declares its own layout, gets
no warning: its own exports take precedence.
- In a `.server.ts`, that warning also names `loader`, `action`,
`actions` and `getPrerenderPaths`. Page method detection doesn't follow
`export *` either, which affects automatic prerendering, action types
and the prerender path list.
- Exports in a Svelte instance script declare component props, so
`export let layout` there is not read as a layout setting and gets no
warning. A layout in a later `<script module>` is still found.
Type-only exports are ignored. Values written as `export const name =
<literal>` are read as before. The cron scanner moves to the new reader
without a change in behavior.
The queues, revalidation, Pages overview and layouts guides now say that
these values must be literals declared with `export const` in the file
itself.
**Behavior change:** an app that shares queue options through another
module now fails to build until each queue file declares them. Those
values were never applied.
## Tests
- `packages/void/test/unit/queue-scan.test.ts`: re-exports, export
lists, a renamed local, `let` and destructuring fail with the message
above. `export * from` warns once, also with a comment or line breaks
between `export` and `*`. Type-only exports, and a file that declares
all four options beside `export *`, stay silent.
- `packages/void/test/unit/pages-scan.test.ts`: a computed `revalidate`,
non-boolean `prerender` and `ssr`, re-exported, renamed, `let` and
destructured settings, unreadable and non-string layouts, and `export *`
in server files and components each warn once and keep the default.
Type-only exports and a layout declared beside `export *` stay silent. A
Svelte `<script module>` or `<script context="module">` layout after an
instance prop named `layout` is read, and an instance prop alone gets no
warning.
Each of the 21 new error and warning cases fails without this fix.
## Verification
- `vp test run`: 785 files pass, 1 skipped (16,406 tests pass, 30
skipped).
- `vp run check`: 33/33 pass.
- The React, Vue, Svelte and Solid Pages playgrounds build without new
warnings.
- Not run: `void deploy` against Cloudflare.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pre-release review found 46 places where Void promised something that the code did not do. The promise was in the docs,
--help, a public type, or an error message.What this PR changes
Each item gets one of three treatments:
Remote R2 in dev now refuses what it cannot do, instead of returning wrong data:
The Astro dev trigger fix is in its own PR, #434, because it changes the dev middleware writer.
Decisions
platform uninstall --delete-zoneandemail domain add --subdomain.layout: './Shell.vue')sendInDevDeployTargetAdapter.capabilities'unsafe-inline'blocks it, and the button stays inert as before.--filevoid.jsoncompatibility pinBehavior changes to note in the release
cognito: setAUTH_COGNITO_DOMAIN,AUTH_COGNITO_REGION,AUTH_COGNITO_USER_POOL_ID, or the same settings inauth.ts.put()with metadata throws when the project deployment is older than this Void version (the object is stored without the metadata).get()with an object-formrangeoronlyIfthrows.ai.provider().fetch()on the platform proxy sends JSON bodies as written, the same as the direct path. Before, file-shaped values were rewritten into an internal marker.void email domain add --subdomainfails at once as an unknown option.shiki.langs,FrontmatterContext,setFrontmatter(),sendInDev,StaticEdgeConfig.assetConfig, the@void/isrlegacy key helpers,DeployTargetCapabilities,DatabaseProvisionResult.projectId,ConnectEventStreamOptions.events,void/remote,ImageFileInput,platform uninstall --keep-zone.Known limits
void db statusandvoid db migrate --remoteon the Void platform still use the first D1 resource. This is unchanged from main.CREATE TRIGGER … BEGIN … ENDin a multi-statement SQL string can fail on real D1 (workers-sdk#15690). Inline--commandalready had this limit.Testing
--file/queryand through a deployed Worker binding (prepare(sql).bind().all()/.run()): every statement runs; a failing statement rolls back the whole requestvp run build:all,vp run check,vp lint,vp fmt --checkvp run test🤖 Generated with Claude Code
https://claude.ai/code/session_0123r5HnanmW2VUrZ7VWDufH