Skip to content

Expand acsoto approver scope - #477

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
acsoto:add-workloadmanager-router-approver
Oct 22, 2026
Merged

volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
acsoto:add-workloadmanager-router-approver

Conversation

@acsoto

@acsoto acsoto commented Oct 16, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

Ownership update.

What this PR does / why we need it:

Add acsoto as approver for workloadmanager, router, docs, examples, and tests.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

git diff --check passed. OWNERS changes only.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Zhou Zihang <z@mcac.cc>
@acsoto

acsoto commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

@RainbowMango

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.19%. Comparing base (5903457) to head (cd44a5d).
⚠️ Report is 18 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   59.98%   60.19%   +0.21%     
==========================================
  Files          36       35       -1     
  Lines        3589     3618      +29     
==========================================
+ Hits         2153     2178      +25     
- Misses       1216     1218       +2     
- Partials      220      222       +2     
Flag Coverage Δ
unittests 60.19% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RainbowMango RainbowMango left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
volcano-sh-bot merged commit 8a03f21 into volcano-sh:main Oct 22, 2026
15 checks passed
@acsoto
acsoto deleted the add-workloadmanager-router-approver branch October 22, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants