Skip to content

Reuse sandbox deletion helpers in workload manager - #485

Open
acsoto wants to merge 2 commits into
volcano-sh:mainfrom
acsoto:cleanup/reuse-sandbox-deletion
Open

acsoto wants to merge 2 commits into
volcano-sh:mainfrom
acsoto:cleanup/reuse-sandbox-deletion

Conversation

@acsoto

@acsoto acsoto commented Oct 23, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Reuse the existing Sandbox and SandboxClaim deletion helpers in garbage collection. Remove unreachable NotFound checks from the delete handler, since the helpers already treat missing resources as successfully deleted.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from acsoto. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Zhou Zihang <z@mcac.cc>
@acsoto
acsoto force-pushed the cleanup/reuse-sandbox-deletion branch from fcd8550 to 6b6df2c Compare October 23, 2026 08:58
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.14%. Comparing base (5903457) to head (654af35).
⚠️ Report is 37 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   59.98%   62.14%   +2.15%     
==========================================
  Files          36       35       -1     
  Lines        3589     3616      +27     
==========================================
+ Hits         2153     2247      +94     
+ Misses       1216     1151      -65     
+ Partials      220      218       -2     
Flag Coverage Δ
unittests 62.14% <100.00%> (+2.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Zhou Zihang <z@mcac.cc>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants