Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Zhou Zihang <z@mcac.cc>
fcd8550 to
6b6df2c
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
+ Coverage 59.98% 62.14% +2.15%
==========================================
Files 36 35 -1
Lines 3589 3616 +27
==========================================
+ Hits 2153 2247 +94
+ Misses 1216 1151 -65
+ Partials 220 218 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Zhou Zihang <z@mcac.cc>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reuse the existing Sandbox and SandboxClaim deletion helpers in garbage collection. Remove unreachable NotFound checks from the delete handler, since the helpers already treat missing resources as successfully deleted.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: