Repository navigation
Fix missing TTL argument in code interpreter test - #486
Conversation
Signed-off-by: Zhou Zihang <z@mcac.cc>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
+ Coverage 59.98% 61.20% +1.21%
==========================================
Files 36 35 -1
Lines 3589 3640 +51
==========================================
+ Hits 2153 2228 +75
+ Misses 1216 1190 -26
- Partials 220 222 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acsoto, LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Pass a zero requested TTL in TestBuildSandboxByCodeInterpreter_DefaultAuthFailsWithoutKey to match the current buildSandboxByCodeInterpreter signature. The missing argument prevents the workloadmanager tests from compiling and causes lint and coverage checks to fail.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: