Skip to content

Fix missing TTL argument in code interpreter test - #486

Merged
volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
acsoto:fix/code-interpreter-test-ttl
Oct 23, 2026
Merged

volcano-sh-bot merged 1 commit into
volcano-sh:mainfrom
acsoto:fix/code-interpreter-test-ttl

Conversation

@acsoto

@acsoto acsoto commented Oct 23, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Pass a zero requested TTL in TestBuildSandboxByCodeInterpreter_DefaultAuthFailsWithoutKey to match the current buildSandboxByCodeInterpreter signature. The missing argument prevents the workloadmanager tests from compiling and causes lint and coverage checks to fail.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Zhou Zihang <z@mcac.cc>
@volcano-sh-bot volcano-sh-bot added the kind/bug Something isn't working label Oct 23, 2026

@LiZhenCheng9527 LiZhenCheng9527 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.20%. Comparing base (5903457) to head (1a88e60).
⚠️ Report is 35 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   59.98%   61.20%   +1.21%     
==========================================
  Files          36       35       -1     
  Lines        3589     3640      +51     
==========================================
+ Hits         2153     2228      +75     
+ Misses       1216     1190      -26     
- Partials      220      222       +2     
Flag Coverage Δ
unittests 61.20% <ø> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acsoto

acsoto commented Oct 23, 2026

Copy link
Copy Markdown
Member Author

/approve

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acsoto, LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
volcano-sh-bot merged commit 8e3f1b1 into volcano-sh:main Oct 23, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants