Skip to content

perf(sequence): build single-match bitmap directly #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 5 commits into from
Aug 9, 2026
Merged

perf(sequence): build single-match bitmap directly #9262

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
544e8e4
optimize sequence compare match bitmap
tomatotomata Aug 7, 2026
d71dc95
bench: follow Vortex benchmark conventions
tomatotomata Aug 7, 2026
5e86532
Revert "bench: follow Vortex benchmark conventions"
tomatotomata Aug 9, 2026
6cdc48b
chore: remove unrelated benchmark changes
tomatotomata Aug 9, 2026
f325e4d
style: restore benchmark file
tomatotomata Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions encodings/sequence/src/compute/compare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use vortex_array::scalar::PValue;
use vortex_array::scalar::Scalar;
use vortex_array::scalar_fn::fns::binary::CompareKernel;
use vortex_array::scalar_fn::fns::operators::CompareOperator;
use vortex_buffer::BitBuffer;
use vortex_buffer::BitBufferMut;
use vortex_error::VortexExpect;
use vortex_error::VortexResult;
use vortex_error::vortex_bail;
Expand Down Expand Up @@ -56,7 +56,9 @@ impl CompareKernel for Sequence {
};

if let Ok(set_idx) = set_idx {
let buffer = BitBuffer::from_iter((0..lhs.len()).map(|idx| idx == set_idx));
let mut buffer = BitBufferMut::new_unset(lhs.len());
buffer.set(set_idx);
let buffer = buffer.freeze();
Comment on lines +59 to +61

@joseph-isaacs joseph-isaacs Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Ok(Some(BoolArray::new(buffer, validity).into_array()))
} else {
Ok(Some(
Expand Down
Loading