[DO NOT MERGE] Focused RowFn take_filter CodSpeed ablation - #9298
Closed
connortsui20 wants to merge 3 commits into
Closed
[DO NOT MERGE] Focused RowFn take_filter CodSpeed ablation#9298connortsui20 wants to merge 3 commits into
connortsui20 wants to merge 3 commits into
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/row-fn-codspeed-take-filter
branch
from
August 9, 2026 13:46
ae7151b to
89fd28b
Compare
Signed-off-by: "Connor Tsui" <connor.tsui20@gmail.com>
Merging this PR will degrade performance by 13.71%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs only
cargo codspeed run --bench take_filterin a pull-request context.The framework-only revision
0a0ad0db1was clean at 232.542 µs versus 233.737 µs for develop. The direct child89fd28bc1, which moves primitive numeric execution to RowFn, reproduced the representative regression at 279.491 µs, or 16.37% slower.This temporary PR has finished its ablation. Do not merge it.