Skip to content

Reference filter and waypoint manager from development - #744

Open
CurryMonsters wants to merge 1 commit into
mainfrom
feat/waypoint-reference-filter-to-main
Open

CurryMonsters wants to merge 1 commit into
mainfrom
feat/waypoint-reference-filter-to-main

Conversation

@CurryMonsters

Copy link
Copy Markdown
Member

Brings reference_filter_dp, reference_filter_dp_quat and waypoint_manager to their state on feat/waypoint-manager-reference-filter: per-waypoint position/orientation tolerances and hold time, goal frames, outcomes and retargeting, reset on mission/wipe, altitude reference and waypoint debug publishing. Also updates landmark_server and the node/simulator tests to the new tolerance fields.

Brings reference_filter_dp, reference_filter_dp_quat and waypoint_manager
to their state on feat/waypoint-manager-reference-filter: per-waypoint
position/orientation tolerances and hold time, goal frames, outcomes and
retargeting, reset on mission/wipe, altitude reference and waypoint debug
publishing. Also updates landmark_server and the node/simulator tests to
the new tolerance fields.

Requires vortex-msgs#70 and vortex-utils#54.
@CurryMonsters
CurryMonsters requested a review from Q3rkses October 7, 2026 11:41
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.32541% with 403 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.07%. Comparing base (0530974) to head (f0ece8a).

Files with missing lines Patch % Lines
...ce_filter_dp_quat/src/ros/reference_filter_ros.cpp 0.00% 168 Missing ⚠️
...sion/waypoint_manager/src/waypoint_manager_ros.cpp 43.45% 82 Missing and 13 partials ⚠️
...ference_filter_dp/src/ros/reference_filter_ros.cpp 38.04% 49 Missing and 8 partials ⚠️
...rence_filter_dp_quat/src/lib/waypoint_follower.cpp 24.24% 25 Missing ⚠️
...nce/reference_filter_dp/src/lib/waypoint_utils.cpp 30.00% 21 Missing ⚠️
.../reference_filter_dp/src/lib/waypoint_follower.cpp 12.50% 14 Missing ⚠️
mission/waypoint_manager/src/frame_resolver.cpp 0.00% 13 Missing ⚠️
...rence_filter_dp/ros/reference_filter_ros_utils.hpp 33.33% 4 Missing ⚠️
...e/reference_filter_dp/test/test_waypoint_utils.cpp 55.55% 0 Missing and 4 partials ⚠️
...andmark_server/src/landmark_server_convergence.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
- Coverage   39.23%   38.07%   -1.16%     
==========================================
  Files          79       80       +1     
  Lines        6520     6910     +390     
  Branches     2478     2619     +141     
==========================================
+ Hits         2558     2631      +73     
- Misses       3284     3589     +305     
- Partials      678      690      +12     
Flag Coverage Δ
unittests 38.07% <26.32%> (-1.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eference_filter_dp/test/test_waypoint_follower.cpp 88.33% <100.00%> (ø)
...nce_filter_dp_quat/test/test_waypoint_follower.cpp 80.64% <100.00%> (ø)
...andmark_server/src/landmark_server_convergence.cpp 0.00% <0.00%> (ø)
...rence_filter_dp/ros/reference_filter_ros_utils.hpp 57.77% <33.33%> (-3.77%) ⬇️
...e/reference_filter_dp/test/test_waypoint_utils.cpp 66.99% <55.55%> (ø)
mission/waypoint_manager/src/frame_resolver.cpp 0.00% <0.00%> (ø)
.../reference_filter_dp/src/lib/waypoint_follower.cpp 73.07% <12.50%> (-26.93%) ⬇️
...nce/reference_filter_dp/src/lib/waypoint_utils.cpp 56.00% <30.00%> (-9.44%) ⬇️
...rence_filter_dp_quat/src/lib/waypoint_follower.cpp 61.53% <24.24%> (-22.07%) ⬇️
...ference_filter_dp/src/ros/reference_filter_ros.cpp 61.02% <38.04%> (-20.95%) ⬇️
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant