Skip to content

scripts: re-vendor featuremap.py from vu1n/dev, pinned - #65

Merged
vu1n merged 1 commit into
mainfrom
claude/project-thread-estucg
Oct 30, 2026
Merged

vu1n merged 1 commit into
mainfrom
claude/project-thread-estucg

Conversation

@vu1n

@vu1n vu1n commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Requested by Vu · project thread

Re-vendors scripts/featuremap.py from vu1n/dev@065e973 with vendor.py, which pins it: its second line is # vendored from vu1n/dev@<sha>; sha256 <hex>, and its own check (already in the python workflow) now fails if the copy is edited here. Changes go to vu1n/dev first, then get vendored again.

New since the last copy: features flags a feature as possibly stale when its paths: changed after its file last did, and check validates any ## User flow (kypp has none, so node isn't needed). The PR touches no worker code.

Verification: python3 scripts/featuremap.py check gives 13 features, 0 broken pointer(s).


Generated by Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T02:14:42.181878Z 6673ad5 PR opened
🔒 Security Review ✅ Completed 2026-10-30T02:15:12.390532Z 6673ad5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@vu1n vu1n left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPS review of 6673ad5: 0 finding(s), 0 blocking.

The change adds vendored-copy integrity checks, feature-map staleness warnings, and optional user-flow validation. The reported test-coverage gap establishes no concrete defect, so this finding does not block merging.

1 finding(s) dropped by the check
  • scripts/featuremap.py:446 Add regression tests for the newly vendored behavior: The workflow exercises only check on the current map, but the finding identifies missing regression tests without demonstrating any reachable incorrect behavior in the new validation or staleness code.

@vu1n
vu1n merged commit e220f76 into main Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant