Repository navigation
scripts: re-vendor featuremap.py from vu1n/dev, pinned - #65
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
vu1n
commented
Oct 30, 2026
vu1n
left a comment
Owner
Author
There was a problem hiding this comment.
VPS review of 6673ad5: 0 finding(s), 0 blocking.
The change adds vendored-copy integrity checks, feature-map staleness warnings, and optional user-flow validation. The reported test-coverage gap establishes no concrete defect, so this finding does not block merging.
1 finding(s) dropped by the check
scripts/featuremap.py:446Add regression tests for the newly vendored behavior: The workflow exercises onlycheckon the current map, but the finding identifies missing regression tests without demonstrating any reachable incorrect behavior in the new validation or staleness code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vu · project thread
Re-vendors
scripts/featuremap.pyfrom vu1n/dev@065e973 withvendor.py, which pins it: its second line is# vendored from vu1n/dev@<sha>; sha256 <hex>, and its owncheck(already in the python workflow) now fails if the copy is edited here. Changes go to vu1n/dev first, then get vendored again.New since the last copy:
featuresflags a feature as possibly stale when itspaths:changed after its file last did, andcheckvalidates any## User flow(kypp has none, so node isn't needed). The PR touches no worker code.Verification:
python3 scripts/featuremap.py checkgives13 features, 0 broken pointer(s).Generated by Claude Code