Repository navigation
recall: rank lessons about deleted code below live ones - #70
Merged
Merged
Conversation
A claim whose every code anchor is unresolved was only labelled stale. ground() now sorts stale claims after live ones; pointer hits keep their place because the query named that anchor.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d516faf283
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Grounding only the capped rows let a stale claim fill the limit while a live match was cut. Recall, browse and the briefing now ground the pool and slice afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vu · project thread
A claim whose every code anchor is unresolved was flagged
stalebut kept its rank.MemoryStore.ground()now sorts stale claims after live ones (stable). Pointer hits keep their place, because the query named that anchor. Local only; the Worker has no checkout and doesn't ground.Contract touched:
ClaimStore.ground(claims, pinned=frozenset()).Verification: new
test_stale_claims_rank_after_live_ones_unless_namedon all three adapters (it fails onmainand passes here).unittest discover314 OK,python -m kypp.store/kypp.view/kypp.mcp_serverOK,featuremap.py check0 broken.Generated by Claude Code