Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A concurrent fork can retain the managed-turn lock's open file description after its owner drops, so the next turn incorrectly reports that the session is still in progress. The parallel invocation-store regression forks the test process and holds inherited descriptors, providing a concrete source for the recurring macOS CI race. Closing only the parent's descriptor cannot release that shared flock.
Explicitly unlock in ManagedTurnLock::drop, matching the invocation-store lock's existing behavior. Keep nonblocking same-session exclusion and independent sessions unchanged. Add a deterministic duplicate-descriptor regression covering release before the duplicate closes, rejected contenders, and successor ownership; update the feature map. No sleeps, retries, or weakened assertions.
Validation:
Runner image publication and live-session/VM qualification remain separate. The libkrun CI job builds, lints, and runs non-VM tests; no deployment or live infrastructure run is included.