Conversation
Signed-off-by: Dmitri Zagidulin <dzagidulin@gmail.com>
|
For reviewers: The folder contains a number of files that are generated, not curated by hand. What is subject to review:
All the other files are generated. Only one of those need real review, exceptionally, namely: The references to the 'old' versions are:
Note: in future, there will be a GitHub setup whereby the generated files will not stay in the repository, but will be generated via a GH action. |
|
This was discussed during the vcwg meeting on 30 September 2026. View the transcriptw3c/vc-data-model#1652brent: The other pull request is from Ivan, this is the first version of the 2.1 version of the vocabulary. ivan: The title makes the PR clear - I started to review the vocab changes due to validFrom and validUntil, I took the opportunity to rework the vocabulary. <TallTed> goodness... +3616 lines across 7 files! brent: One of the difficulties in review this is that there are new files. Would it be possible to generate some sort of diff? ivan: I can do that, but the diffs are so big, all the terms in the JSON-LD Context that are not in the vocabulary had to be added to the vocabulary to make the tool work. brent: Please comment in the PR providing pointers to what should be reviewed vs what is generated. manu: I have a general question about the threat model for VCDM. We don't have an issue for this. I feel weird being the only person listed on that document - I suggest we put all of the authors of the VCDM on it, since it inherited the security and privacy considerations of the document. brent: I think this makes sense - do others have thoughts? <Antony> makes sense ! <Elaine> Didn’t we do a brainstorm. Maybe people involved in that phila: Yes, it is a group effort, unless there is an objection, please add the other names. <TallTed> suggested issue sort order -- https://github.com/w3c/vc-data-model/issues?q=is%3Aissue+state%3Aopen+sort%3Aupdated-asc wes-smith: If we migrate the authors over should they be added as authors to the threat model, not editors. manu: +1 <brent> https://github.com/w3c/vc-data-model/issues brent: There are some open issues for VCDM. |
| label: Subresource integrity digest | ||
| defined_by: https://www.w3.org/TR/vc-data-model-2.1/#defn-digestSRI | ||
| range: cred:sriString | ||
| see_also: | ||
| - label: Subresource Integrity Metadata |
There was a problem hiding this comment.
Sentence case? or Title case?
I think we should pick one, and make it consistent throughout.
There was a problem hiding this comment.
I usually prefer sentence case. I have handled this one in e2b3c3b
TallTed
left a comment
There was a problem hiding this comment.
Some specific changes, some general comments.
Another general comment: A number of stanzas lack label:. I've suggested some specifics; it seems likely that all stanzas should get them added.
…-model into start-vocabulary-v21
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Thanks @TallTed , much appreciated. I merged/handled your comments |
…is also referred to from the abstract
This PR is to fix #1651, but it is more than that: based on the discussion in #1651 (comment) it proposes a new folder in the repository with the new, 2.1 version of the vocabulary.
Apart from the issues in #1651, the new version includes:
After the merge of this PR, we should also update the github actions. The goal is that the generated html/turtle/json-ld files would not be part of the repository; they would be generated on the fly for the github pages by a relevant action.
Note: this PR does not touch the JSON-LD context file. That is maintained somewhere else...