Skip to content

fix: added trap for non-aligned list pointers #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jairus (JairusSW) merged 1 commit into from
Oct 1, 2026
Merged

fix: added trap for non-aligned list pointers #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/abi/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,9 @@ func allocStoreList(mem []byte, list []Value, elemType bintype.TypeDesc, resolve
if err != nil {
return 0, 0, fmt.Errorf("realloc failed: %w", err)
}
if newPtr%elemAlign != 0 {
return 0, 0, fmt.Errorf("realloc return: %s pointer %d not aligned to %d", elemType.Kind(), newPtr, elemAlign)
}

if _, _, err := checkedRange(len(mem), newPtr, byteLen); err != nil {
return 0, 0, fmt.Errorf("allocated memory out of bounds: ptr=%d size=%d", newPtr, byteLen)
Expand Down
1 change: 0 additions & 1 deletion testdata/conformance/xfail.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@
"values__post-return__0015__L215/action/L216": "required canonical ABI trap is not enforced",
"values__post-return__0029__L229/action/L230": "required canonical ABI trap is not enforced",
"values__post-return__0043__L243/action/L244": "required canonical ABI trap is not enforced",
"values__realloc__0006__L93/action/L94": "required canonical ABI trap is not enforced",
"values__transcode__0000__L7/action/L113": "canonical transcoding semantics are incomplete",
"values__transcode__0002__L117/action/L201": "217: call: component/instance: export \"run\": call core func \"run\": component/instance: host import \"join\" \"\": component/instance: export \"join\": call core func \"join\": wasm trap...",
"values__transcode__0004__L205/action/L319": "canonical transcoding semantics are incomplete",
Expand Down
Loading