Repository navigation
perf: reuse immutable TLS profile snapshots - #5
Draft
Joshua Tenner (jtenner) wants to merge 2 commits into
Draft
Joshua Tenner (jtenner) wants to merge 2 commits into
Joshua Tenner (jtenner) wants to merge 2 commits into
Conversation
Joshua Tenner (jtenner)
force-pushed
the
agent/tls-full-grid
branch
from
November 2, 2026 18:08
eddbfa6 to
5b5177f
Compare
Joshua Tenner (jtenner)
force-pushed
the
agent/tls-allocation-hardening
branch
from
November 2, 2026 18:14
4c844be to
7905945
Compare
Joshua Tenner (jtenner)
force-pushed
the
agent/tls-full-grid
branch
from
November 2, 2026 18:47
5b5177f to
8b9c944
Compare
Joshua Tenner (jtenner)
force-pushed
the
agent/tls-allocation-hardening
branch
from
November 2, 2026 18:47
7905945 to
d10e532
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack status
agent/tls-full-grid4c844beeddbfa630186510604passed every required check for head4c844beon July 26, 2026Summary
Removes redundant per-stream deep copies of TLS profile state while preserving the existing immutable profile boundary and fail-closed validation.
crypto/tls.Config's shallow per-connection shell needed to set the authorizedServerNamecrypto/tls.Conn, transport, and profile references immediately after workers join, so stale closed wrappers cannot pin large buffers or certificate/CA graphsCorrectness and race evidence
Allocation and performance evidence
Controlled linux/amd64 Go 1.24.4 benchmarks:
391,650 B/op, 964 allocations before;390,050 B/op, 952 allocations after391,220 B/op, 954 allocations before;389,650 B/op, 948 allocations after382 KiB/op, 45 allocations, 40–44 µs before;282 KiB/op, 37 allocations, 30–35 µs afterThe complete benchmark smoke matrix discovers and passes 174 top-level targets in 50 packages, expanding to 204 result names.
Validation
go test -shuffle=on -count=1 ./...go vet ./...scripts/tls-signoff.shscripts/benchmark-smoke.shmatrixExplicitly unchanged
No guest ABI, capability, cryptographic primitive, TLS version default, session-resumption authority, listener authority, TinyGo support claim, or release-adoption claim changes in this pull request.
2026-11-02 restack
Rebased onto PR #3 head
8b9c9445b08eb510788199d40285f9c971014505; current head isd10e532605581622a1aecd78945002a9b59d467d. Current TLS signoff resolves 170 targets across 17 package runs. Full ordinary, shuffle, vet, source-boundary, race, checkptr, backend-neutral 386,wagodebug,wago_regalloccheck, three-mode benchmark-compilation, and TLS signoff gates passed locally, along with 100 checkptr and 100 race repetitions of the repaired peer-plaintext test. July allocation and timing results remain historical; no benchmark timing was executed during this restack. Rewritten commits are unsigned because no desktop signing agent was available.