Repository navigation
jarvisctl keys: issue, revoke and list per-tenant API keys - #115
Conversation
…ox (tokens to a mode-600 file, never printed) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40e77690cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…Codex on #115) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e7836aef6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…are 'unavailable', never zero (Codex on #115) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f04f33fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…perator copy never changes owner (Codex P1 on #115) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
RFC phase 1 leftover: the box-side wrappers for per-tenant API keys. Schema v10 is already live with key authentication off; this only adds the operator tooling.
deploy/mint/bin/keys.sh+jarvisctl keys ...: pepper-init, tenant-create, key-create, key-revoke, tenant-status, tenants, keys, status. Runspython -m app.tenant_keysin the migrate container as the migrator, as the host user, pepper mounted read-only (never a value, never on a command line).key-createrequires--out NAMEand writes secrets/issued-keys/NAME.token (mode 600, dir 700, never overwritten). The pepper is created once (mode 600, never overwritten, value not shown). Every argument is validated before Docker is touched (exit 2).Tests: tests/test_deploy_keys.py (44, fake docker); seven mutants (overwrite checks, pepper passed by value, tenant regex, mode check, printing the pepper, wrong user) each caught. Also checked against a throwaway Postgres with the real v10-main image in a read-only container: token file is mode 600 owned by the host user, an existing file is refused without leaving a key row, a missing pepper fails closed. Nothing was run on the live box.
🤖 Generated with Claude Code