Repository navigation
compose: MCP write flag from deploy/mint/.env (default off) - #117
Merged
Merged
Conversation
…t off) It was hard-coded to "false" in the app's environment block, which beats secrets/app.env, so MCP writes could not be enabled without editing a tracked file on the box. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JARVIS_MCP_WRITE_ENABLEDwas hard-coded to"false"in the app service'senvironment:block, which takes precedence oversecrets/app.env. Turning MCP writes on therefore needed an edit to a tracked file on the box (a dirty live checkout).Now
JARVIS_MCP_WRITE_ENABLED: ${JARVIS_MCP_WRITE_ENABLED:-false}, the same pattern asJARVIS_SIGNATURES: set it indeploy/mint/.envand recreate the app. Unset, empty or anything but true stays OFF. No behaviour change until someone sets it.Verified with
docker compose configin the live deploy dir (value printed only): unset -> false, empty -> false, true -> true, false -> false. Test pins the exact line and the .env.example entry. Nothing deployed.The write tools stay draft-only, need user_requested=true, work for the ledger key only (the recall key is refused).
🤖 Generated with Claude Code