Skip to content

Add table-driven tests for the MSVC default-library and linker-option builder #628

Description

@LunaStev

Part of #611. Difficulty: good first issue. Audit baseline: master 3950416e (2026-09-12).

Current evidence

llvm/src/backend.rs exposes msvc_link_args. Existing MSVC foundation coverage mainly asserts the custom-entry /NODEFAULTLIB dry-run path, leaving its static/dynamic hosted library lists and several option combinations without focused table coverage.

Scope

Test the existing argument builder directly for x64/ARM64 machine flags, EXE versus DLL, static versus dynamic CRT, no-default-libraries, entry points, paths/libraries and user argument ordering. Use structured argument comparisons rather than broad substring checks. No native SDK or linker should be required for these unit tests.

Completion criteria

Verify exactly the applicable runtime library family is selected, /NODEFAULTLIB suppresses defaults, .lib suffixes are not doubled, and paths with spaces remain single arguments. Retain explicit extra-argument order and correct /MACHINE, /DLL or /SUBSYSTEM selection. Do not change CRT policy under a test-only issue; report any discovered semantic defect separately.

Dependencies and boundaries

#498; helps #617. Completed #571 already corrected broad independence assertions and should not be reopened.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are good for newcomers or first-time contributors.help wantedThe issue requires extra attention or help from others.needs testingIssues that require additional testing or verification.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions