fix(tools): treat explicit wavec overrides as authoritative in corpus checker - #590
Merged
LunaStev merged 1 commit intoSep 11, 2026
Merged
Conversation
… checker Signed-off-by: Visio Vanitas <visiovanitas@atdove.dev>
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treat explicit
--wavecarguments and non-emptyWAVECenvironment variables as authoritative intools/check_wave_corpus.py, immediately raisingFileNotFoundErrorif the specified binary cannot be found or resolved rather than silently falling back to local build discovery.Motivation
Resolves #564. Previously,
resolve_waveccombined explicit--wavec,WAVEC, and local build candidate paths into a single candidate list. If the user provided an invalid or misspelled--wavecpath (orWAVECenv variable), the corpus checker fell back to local build paths, potentially validating a stale or unrelated binary.Target and compatibility impact
None. Discovery fallback is retained when neither
--wavecnorWAVECis provided or whenWAVECis empty.Validation
tools/test_check_wave_corpus.pycovering:--wavecpath fails immediately without falling back to existing build outputs.WAVECenvironment variable fails immediately without selecting fallback.--wavecpath is selected.WAVECenvironment variable is selected.WAVECenvironment variable falls back to discovery.FileNotFoundError.python3 -m unittest tools.test_case_manifest tools.test_test_contracts tools.test_process_tree tools.test_check_wave_corpuspython3 -m unittest discover -s tools -p "test_*.py"python3 -m py_compile x.py tools/*.pyChecklist
Signed-off-byline.std/.