Fix MSVC C4996/C4242 warnings in C API#214
Merged
wavefunction91 merged 2 commits intoJun 25, 2026
Merged
Conversation
lorisercole
commented
Jun 23, 2026
lorisercole
commented
Contributor
- c_status.hpp: replace std::strcpy with std::memcpy using the already computed length. Avoids C4996 (deprecation of strcpy) portably without resorting to _CRT_SECURE_NO_WARNINGS or the non-portable strcpy_s.
- c_xc_integrator.cxx: replace ::toupper passed to std::transform with a lambda that takes unsigned char and casts the result back to char. Fixes C4242 (int->char loss-of-data) and avoids UB when char is signed.
- c_status.hpp: replace std::strcpy with std::memcpy using the already computed length. Avoids C4996 (deprecation of strcpy) portably without resorting to _CRT_SECURE_NO_WARNINGS or the non-portable strcpy_s. - c_xc_integrator.cxx: replace ::toupper passed to std::transform with a lambda that takes unsigned char and casts the result back to char. Fixes C4242 (int->char loss-of-data) and avoids UB when char is signed.
wavefunction91
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.