Repository navigation
fix: refresh expired Azure DevOps guest git credentials - #59
Merged
Merged
Conversation
Guest get replayed an expired Azure DevOps JWT, and erase left the stale protocol+host entry in the store. get now misses and drops a JWT whose exp is within 60 seconds. erase removes every protocol+host match. refresh-credentials re-seeds a running container. Real start and up start-stopped re-seed; already-running start does not. Non-Azure helper chaining is unchanged. Azure seeding no longer writes an empty URL-scoped helper reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getreplayed an expired Azure DevOps JWT, so a rotated host token never replaced the stale guest entry.eraseleft that protocol+host entry in the store.getnow misses and drops a JWT whoseexpis within 60 seconds.eraseremoves every protocol+host match. A non-JWT password, a missingexp, or a decode failure is still returned.adevcontainer refresh-credentials [--name]re-seeds an already-running container from hostgit credential fill. It does not start, stop, fetch, pull, push, or write the workspace. A stopped target fails with a hint tostart --name.startandupstart-stopped re-seed after the container is running and before restart postStart. Refresh failure soft-fails and does not fail the command. Already-runningstartandupreuse do not refresh.credential.https://dev.azure.com.helperreset. Non-Azure helper chaining is unchanged. Credential material enters the guest via stdin only.Verification
swift run adevcontainerTests: 1176 passed, 0 failed, 5 skipped.refresh-credentialswas verified on a running container.