You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add support for new generative-digitalocean module #2149
Hi @antas-marcin — I'd like to take this on. I checked python-client main at 0791933 and the current server generative.proto. The implementation appears to require: (1) GenerativeSearches.DIGITALOCEAN plus Configure.Generative.digitalocean(...) for collection configuration, (2) a runtime _GenerativeDigitalOcean / GenerativeConfig.digitalocean(...) mapping to GenerativeProvider.digitalocean, including stop as TextArray, (3) refreshed protobuf bindings for the supported protobuf runtimes, and (4) focused coverage in test_config.py and test_classes_generative.py plus the changelog. I also confirmed there is currently no open DigitalOcean PR. One question before I start: server main now also contains GenerativeMeta, added after this issue. Would you prefer the protobuf refresh to include both new wire types while keeping the public Python API changes in this PR DigitalOcean-only, or should I pin generation to the DigitalOcean proto commit so the generated diff stays isolated?
Just one warning, this task is time critical, we would like to have it shipped before the end of this week. If you do decide to take this on, please check "Allow edits from maintainers" when creating the PR so I can make edits directly and get it over the finish line fast. And if the timeline doesn't work for you, just say so and I'll cover it, you can also take on another issue that suits you.
On the proto question: regenerate from the tip of main (weaviate/proto/v1/regen.sh) and let the generated files include both GenerativeDigitalOcean and GenerativeMeta. Keep the public Python API changes DigitalOcean-only.
Activity
denis-samatov commentedon Aug 31, 2026
Hi @antas-marcin — I'd like to take this on. I checked python-client
mainat0791933and the current servergenerative.proto. The implementation appears to require: (1)GenerativeSearches.DIGITALOCEANplusConfigure.Generative.digitalocean(...)for collection configuration, (2) a runtime_GenerativeDigitalOcean/GenerativeConfig.digitalocean(...)mapping toGenerativeProvider.digitalocean, includingstopasTextArray, (3) refreshed protobuf bindings for the supported protobuf runtimes, and (4) focused coverage intest_config.pyandtest_classes_generative.pyplus the changelog. I also confirmed there is currently no open DigitalOcean PR. One question before I start: servermainnow also containsGenerativeMeta, added after this issue. Would you prefer the protobuf refresh to include both new wire types while keeping the public Python API changes in this PR DigitalOcean-only, or should I pin generation to the DigitalOcean proto commit so the generated diff stays isolated?g-despot commentedon Sep 2, 2026
Hi @denis-samatov, thanks for volunteering 😄
Just one warning, this task is time critical, we would like to have it shipped before the end of this week. If you do decide to take this on, please check "Allow edits from maintainers" when creating the PR so I can make edits directly and get it over the finish line fast. And if the timeline doesn't work for you, just say so and I'll cover it, you can also take on another issue that suits you.
On the proto question: regenerate from the tip of
main(weaviate/proto/v1/regen.sh) and let the generated files include bothGenerativeDigitalOceanandGenerativeMeta. Keep the public Python API changes DigitalOcean-only.g-despot commentedon Sep 3, 2026
Hi @denis-samatov! Thanks again for the contribution. You need to post a comment in your PR agreeing to the CLA.