Repository navigation
chore(deps): raise the grpcio upper bound to <2.0.0 - #2227
Draft
ColtonRobak wants to merge 2 commits into
Draft
ColtonRobak wants to merge 2 commits into
ColtonRobak wants to merge 2 commits into
Conversation
Google Cloud's Python libraries will require grpcio>=1.83.0 from April 2027, and the <1.80.0 bound makes weaviate-client uninstallable next to them. Add grpcio 1.85.0 and protobuf 6.33.6 to the CI matrices. Closes #2226 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
grpcio-tools used to choose protobuf for each integration entry. Without it, pip installed protobuf 6 next to grpcio 1.66.0 and 1.70.0, which the client rejects with WeaviateProtobufIncompatibility. Pin the protobuf major each entry had before, and move the 3.10 entry to the 1.59.5 floor so pip no longer swaps it for the newest grpcio. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
==========================================
+ Coverage 89.23% 89.26% +0.02%
==========================================
Files 312 312
Lines 24715 24736 +21
==========================================
+ Hits 22055 22081 +26
+ Misses 2660 2655 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2226
Raises the
grpciorequirement from>=1.59.5,<1.80.0to>=1.59.5,<2.0.0, the range used before #1682. Google Cloud's Python libraries will requiregrpcio>=1.83.0from April 2027 (googleapis/google-cloud-python#18451), and the current cap makes weaviate-client uninstallable next to them after that.CI now covers the new range:
proto-testadds grpcio 1.85.0 and protobuf 6.33.6, andintegration-testsadds a Python 3.14 / grpcio 1.85.0 entry. The integration job now pinsgrpcioandprotobufper entry instead of installing grpcio-tools and grpcio-health-checking, which only set protobuf indirectly: 1.84.0+ of both require protobuf 7, whichprotobuf<7.0.0excludes, and the integration tests use neither (the client dropped them in #1788). Each existing entry keeps the protobuf major it had before (4.x, 5.x or 6.x), and the 3.10 entry moves from grpcio 1.59.0 to the 1.59.5 floor, since below the floorpip install .replaces it with the newest allowed grpcio, now 1.85.0.Verification
Same source on Python 3.12 with protobuf 6.33.6, run under grpcio 1.78.0 and 1.85.0, with identical results:
proto_test: 4 passedtest: 564 passed, 1 skippedmock_tests(run serially): 71 passedci/docker-compose.ymlonly): 834 passed, 5 failed, 44 skipped, with no test changing outcome between the two runs. The 5 failures need the async-indexing (port 8090) and OIDC servers, which weren't running.google-api-core[grpc]==2.43.0andgrpcio>=1.83.0(resolves grpcio 1.85.0, grpcio-status 1.85.0, protobuf 6.33.6); 4.24.1 fails withResolutionImpossible.Note for reviewers
The generated
*_pb2_grpc.pyversion check importsgrpc._utilities.first_version_is_lower, a private grpcio helper. It's still in 1.85.0, and the newproto-testentry would catch its removal. If you'd rather keep a minor-version band,<1.90.0covers this too; the CI entries are what keep the new range tested.🤖 Generated with Claude Code