Repository navigation
fix: preserve single-component vector conversion - #2229
Open
DiadkoShmek wants to merge 1 commit into
Open
DiadkoShmek wants to merge 1 commit into
DiadkoShmek wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree to the Weaviate Contributor License Agreement: https://weaviate.io/service/contributor-license-agreement |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep a single-component embedding as a list when
get_vector()squeezes a supported array or tensor.np.array([0.5])andpd.Series([0.5])currently become the scalar0.5, despite the helper's list-return contract._Pack.single()then raisesTypeError: object of type 'float' has no len(); the equivalent Python list works.Wrap scalar conversion results in a list in both the direct
squeeze().tolist()path and thenumpy()fallback. Existing list results are retained, without flattening multi-vectors or changing request shape classification.Validation
main(d1e185eaa5425cc0884c28689bbaa11d5eec7898), the vector test file reports 4 failed, 9 passed. With this change, vector, utility and byte-operations tests report 57 passed.git diff --check: passed on both changed files.Real TensorFlow/PyTorch runtimes and server integration were not tested. The helper also normalizes a zero-dimensional array conversion to a list; zero-dimensional query input remains rejected by the existing shape classifier.
AI disclosure: Codex prepared and tested this change, with a separate AI review of the complete diff and focused cases. No personal human code review is claimed.