[Gecko Bug 2063757] Make PresShell::CompleteMove ignore native anonymous subtrees - #62153
Open
moz-wptsync-bot wants to merge 1 commit into
Open
[Gecko Bug 2063757] Make PresShell::CompleteMove ignore native anonymous subtrees#62153moz-wptsync-bot wants to merge 1 commit into
PresShell::CompleteMove ignore native anonymous subtrees#62153moz-wptsync-bot wants to merge 1 commit into
Conversation
The content nodes in a UA shadow is not accessible via Selection API even though they are selectable by user's operation (e.g., dragging text of the default `<summary>`). Therefore, `Selection::Modify` should not move caret into UA shadow. When `Selection::Modify` cannot find next or previous line when the amount is "line", it falls back to `PresShell::CompleteMove`. However, `PresShell::CompleteMove` allows to move selection into native anonymous subtree even though the selection in them may not be managed by the document level selection. So, `PresShell::CompleteMove` should call `nsIFrame::GetExtremeCaretPosition` with `nsIFrame::IGNORE_NATIVE_ANONYMOUS_SUBTREE`. Differential Revision: https://phabricator.services.mozilla.com/D320083 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2063757 gecko-commit: 2e2c06850c7a3469d88c11c729a0fce244434ec9 gecko-commit-git: 84192a505ed266582d75b83acbbc557e21ced43f gecko-reviewers: emilio, layout-reviewers
wpt-pr-bot
approved these changes
Aug 22, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content nodes in a UA shadow is not accessible via Selection API
even though they are selectable by user's operation (e.g., dragging
text of the default
<summary>). Therefore,Selection::Modifyshouldnot move caret into UA shadow.
When
Selection::Modifycannot find next or previous line when theamount is "line", it falls back to
PresShell::CompleteMove. However,PresShell::CompleteMoveallows to move selection into native anonymoussubtree even though the selection in them may not be managed by the
document level selection.
So,
PresShell::CompleteMoveshould callnsIFrame::GetExtremeCaretPositionwithnsIFrame::IGNORE_NATIVE_ANONYMOUS_SUBTREE.Differential Revision: https://phabricator.services.mozilla.com/D320083
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2063757
gecko-commit: 2e2c06850c7a3469d88c11c729a0fce244434ec9
gecko-commit-git: 84192a505ed266582d75b83acbbc557e21ced43f
gecko-reviewers: emilio, layout-reviewers