[JUM-903][CI] Run ci:gate checks that no CI job ran as a branch-gate preflight - #534
Merged
Merged
Conversation
…light JUM-903. Hosted CI never executes the ci:gate script, so twelve steps listed only there ran nowhere; the CLI template freshness check was failing on dev with every required check green. ci:gate:static groups the cheap checks and runs before every gate; frontend:coverage:check joins the CircleCI coverage job; ci-gate-coverage.test.ts fails when a step is added to ci:gate alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c38964c2-e860-4f6f-95a1-31353176ffa1) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_dbde3baa-3c7f-45e9-a1cf-01fe73556fb0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
ci:gatestep now runs in some CI path. Hosted CI never executes theci:gatescript, so twelve steps listed only there ran nowhere — includingcli:check-template-freshness, which was failing ondevwith all required checks green (fixed by JUM-902). Newci:gate:staticgroups the cheap checks and runs as a branch-gate preflight on every gate;frontend:coverage:checkjoins the CircleCI coverage job; a coverage suite fails when a step is added toci:gatealone.Problem Statement
Measured on
devdd9c2da:deps:check-overrides,deps:audit,arch:check-http-adapters,governance:check-authorship,packages:check-suites,packages:check-build-freshness,cli:check-template-freshness,website:check-content-routes,rtdb:check-indexes,ci:check-provider,frontend:coverage:check,oas:check-relationsappear in no preflight, no strict-matrix cell and no CircleCI step. Same failure shape as JUM-683 / JUM-786.Project Tracking (Required)
Jumentix(https://linear.app/jumentix)Start date->End date): 2026-09-26 -> 2026-10-06P0/P1/P2): P1Branch Promotion Path (Required)
[JUM-XXXX][Nature] <concise outcome>JUM-XXXXmatches the single Linear Issue declared above.dev.main, it is a release promotion sourced fromdev, references the task PRs/issues already merged intodev, and introduces no unreviewed changes.main.Bidirectional Traceability (Required)
JUM-903: 2f9587eScope of Change
Domain / Business Rules
Application / Use Cases
Adapters / Infrastructure
package.json:ci:gate:static(11 steps).ci-cd/run-branch-quality-gate.js:static-gatespreflight on task, unit, full-matrix and generated-automation gates..circleci/config.yml:bun run frontend:coverage:checkafterfrontend:test:coveragein the coverage job.ci-cd/test/ci-gate-coverage.test.ts:ci:gate⊆ preflight ∪ gate scripts ∪ matrix ∪ci:gate:static∪ named CI steps; negative control with an imaginary step; stale exception entries fail.API / Contracts (OpenAPI, DTOs, handlers, controllers)
Detailed Technical Changes
deps:auditmeasured on a cleanbun install --frozen-lockfile:[deps:audit] no blocking advisories.(2539 packages). A reused local store reported 11 fatal advisories from stale versions (next 16.3.0, happy-dom 20.0.11, …) that the lockfile no longer resolves — CI always installs fresh, so this is a local-only false positive, noted here rather than fixed.ci:gate:staticruns in ≈5.5 s locally.TESTING-CI-AND-QUALITY.md(EN + pt-BR) documents the preflight.Architecture and Design Alignment
Security Impact
Data and Migration Impact
Breaking Changes
None.
Acceptance Criteria
Test Plan (Evidence)
bun run lint— cleanbun run test:unit— task gate: Tests: 1156 passed, 1156 totalbun run ci:gate:static— all 11 passed after JUM-902 rebuilt the templatesbun run frontend:coverage:check— lines 90.60% (threshold 85%), functions 87.51% (80%)bun run ci:gate— not run in full locally; CircleCI is authoritativeExtra evidence:
Feedback Resolution (Required)
resolved, a SHA from this PR.Coverage
SonarQube Cloud
Performance / Reliability Impact
No measurable impact.
Observability
Deployment and Rollout
dev, promote with the next release.Risks and Mitigations
Documentation Updates
mainmergeReviewer Checklist
🤖 Generated with Claude Code
Note
Low Risk
CI orchestration and test expectations only; no application runtime or auth/data paths change, with regression guarded by new coverage tests.
Overview
Fixes JUM-903: hosted CircleCI never runs the monolithic
ci:gatescript, so several checks (including CLI template freshness) could fail ondevwhile required PR checks stayed green.Adds
ci:gate:staticinpackage.jsonto bundle eleven cheap static/audit checks and wires a newstatic-gatespreflight (ci:gate:static) into every branch-quality-gate path inrun-branch-quality-gate.js(task, unit, full matrix, generated automation). The CircleCI coverage job now runsfrontend:coverage:checkafter frontend patch coverage.A new gate-tier suite
ci-gate-coverage.test.tsasserts everyci:gatestep is exercised via preflight, strict matrix,ci:gate:static, or a named CI job, with branch-gate tests and EN/pt-BR CI docs updated accordingly.Reviewed by Cursor Bugbot for commit 7f2df35. Bugbot is set up for automated code reviews on this repo. Configure here.