[JUM-898][Feature] Warn when a product screenshot may be stale - #546
Merged
Merged
Conversation
JUM-896. Replace the July Domain Designer capture and add five more from the running apps: architecture designer, OpenAPI tab, code workspace, and the frontend's admin list and dashboard. The product page opens with a tour of the six; the homepage caption no longer claims "the real interface" of a screen that had changed. scripts/capture-product-screenshots.mjs (bun run --filter @jumentix/website screenshots:capture) regenerates all of them with fixed framing; COMMERCIAL-EXPERIENCE (EN + pt-BR) documents it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JUM-898. Product screenshots under public/product/ had no link back to the feature or commit they depict, so a UI change could leave a stale image on the site indefinitely with nothing to notice it. screenshots.json records, per image, the commit it was captured at and the source paths of the screen it shows; check-screenshot-freshness.mjs warns (never fails) when a watched path changed since that commit, naming the commits, and fails only when the manifest itself is wrong (missing image, untracked image, no watch list, or an unresolvable commit — a shallow clone just warns instead). capture-product-screenshots.mjs now stamps every entry with the commit it just captured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-screenshot-freshness # Conflicts: # apps/jumentix-website/documentation/COMMERCIAL-EXPERIENCE.md # apps/jumentix-website/documentation/COMMERCIAL-EXPERIENCE.pt-BR.md # apps/jumentix-website/scripts/capture-product-screenshots.mjs # test-map.json
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b84b639c-9431-4f64-94bc-585067464ff9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/jumentix-website/public/product/had no link back to the feature or commit they depict, so a UI change could leave a stale image on the site indefinitely with nothing to notice it.public/product/screenshots.jsonrecords, per image, the commit it was captured at (capturedAt) and the source paths of the screen it shows (watch).check-screenshot-freshness.mjswarns (never fails) when a watched path changed since that commit, naming the commits; it fails only when the manifest itself is wrong (missing image, untracked image, no watch list, or an unresolvable commit — a shallow clone just warns instead).capture-product-screenshots.mjsnow stamps every manifest entry with the commit it just captured.ci:gateandci:gate:static(the branch-gate preflight) aswebsite:check-screenshot-freshness, alongsidewebsite:check-content-routes.Test plan
check-screenshot-freshness.test.mjs— 8/8 passing, pure unit tests with injected IO (no real git/fs calls)bun run website:check-screenshot-freshnessagainst the real manifest — clean, 0 stalebun run test-map:check— fresh after regenerating post-merge🤖 Generated with Claude Code
Note
Low Risk
Changes are limited to website CI/docs and a non-blocking staleness warning; only manifest integrity errors fail the gate.
Overview
Product marketing screenshots can drift from the UI with no signal. This PR adds a
screenshots.jsonmanifest underpublic/product/that records each PNG’s capture commit (capturedAt) andwatchpaths for the code that shapes that screen.The capture script now rewrites every manifest entry’s
capturedAtto the currentHEADwhen writing to the default output dir (customSCREENSHOT_OUTskips the manifest).check-screenshot-freshness.mjscompares watched paths to git history: warnings only when commits landed after capture (with sample commit messages in the gate log), exit 1 only for a broken manifest (missing/extra images, emptywatch, bad JSON, unknown commit in a full clone). Shallow clones warn instead of failing on missing history.website:check-screenshot-freshnessis wired intoci:gateandci:gate:static, with unit tests andtest-map.jsonupdated. EN/PT commercial docs describe the manifest and recapture workflow (commit images + manifest together).Reviewed by Cursor Bugbot for commit b1407f1. Bugbot is set up for automated code reviews on this repo. Configure here.