WTEL-9794: Fix Today filter timezone in patchMembers - #358
Open
vlad-marusyk-wt wants to merge 1 commit into
Open
WTEL-9794: Fix Today filter timezone in patchMembers#358vlad-marusyk-wt wants to merge 1 commit into
vlad-marusyk-wt wants to merge 1 commit into
Conversation
kirychukyurii
requested changes
Aug 3, 2026
| and (:Id::int8 isnull or m.id = :Id::int8) | ||
| and (:Today::bool isnull or not :Today::bool or (:Today and m.created_at >= now()::date)) | ||
| and (:Today::bool isnull or not :Today::bool | ||
| or (m.created_at at time zone coalesce(tz.sys_name, 'UTC'))::date = (now() at time zone coalesce(tz.sys_name, 'UTC'))::date) |
Contributor
There was a problem hiding this comment.
coalesce(tz.sys_name, 'UTC'))::date
якщо у мембера відсутня часова зона, то вона береться з календаря черги як fallback
| ) | ||
| and (:Name::varchar isnull or m.name ilike :Name) | ||
| and (:Id::int8 isnull or m.id = :Id::int8) | ||
| and (:Today::bool isnull or (:Today and m.created_at >= now()::date)) |
Contributor
There was a problem hiding this comment.
тут є аналогічний функціонал, тому варто було б це додати в коментарі в джиру, можливо в рамках окремої таски потрібно реалізувати
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
Фільтр today у patchMembers порівнював created_at з now()::date, тобто рахував "сьогодні" за поясом сервера БД (UTC) і ігнорував часовий пояс мембера.
Вирішення
"Сьогодні" тепер обчислюється в поясі мембера: join flow.calendar_timezones по m.timezone_id і порівняння локальних дат через at time zone.
Зміни