add minimum data types and rank range for operations#910

Open

BruceDai wants to merge 19 commits into

webmachinelearning:mainfrom

BruceDai:minimum_datatype_rankrange

BruceDai commented Dec 10, 2025 •

edited by pr-preview Bot

Loading

Contributor

This PR is to fix #896.
@huningxin @fdwr @reillyeon PTAL, thanks!

BruceDai changed the title ~~add minimum data types and rank range for operations~~ [wip]add minimum data types and rank range for operations

BruceDai commented

View reviewed changes

index.bs

BruceDai commented

View reviewed changes

index.bs

BruceDai commented

View reviewed changes

index.bs Outdated

BruceDai commented

View reviewed changes

index.bs Outdated

BruceDai changed the title ~~[wip]add minimum data types and rank range for operations~~ add minimum data types and rank range for operations

fdwr commented Dec 12, 2025 •

edited

Loading

Collaborator

I checked the unchanged Line 8987, it seems correct by using current 8 indents for to match front
of also 8 indents. Any suggestions? Thanks!

@BruceDai : Remerge with main. My PR adds an extra blank line that pacifies the build error (and yes, that line was already correct, and nothing changed there for months, but bikeshed changed).

BruceDai commented

View reviewed changes

index.bs

reillyeon suggested changes

View reviewed changes

index.bs Outdated

reillyeon approved these changes

View reviewed changes

reillyeon left a comment

Member

General wording looks good. I have not validated the specific operator limits specified.

index.bs Outdated

index.bs Outdated

fdwr reviewed

View reviewed changes

fdwr left a comment

Collaborator

👀 Thanks for the updates Bruce - I'm sure they were tedious :b.

index.bs Outdated

index.bs Outdated

index.bs

index.bs Outdated

index.bs

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs

index.bs

huningxin reviewed

View reviewed changes

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs Outdated

fdwr mentioned this pull request

Introduce BitCast (reinterpret cast) onnx/onnx#6887

Closed

BruceDai commented Dec 22, 2025

Contributor Author

Thanks @huningxin and @fdwr for review and identifications. 👍
I submitted a new commit to address your comments. Please take another look, thanks!☕

BruceDai force-pushed the minimum_datatype_rankrange branch 2 times, most recently from 949a42f to b6b300f Compare

January 16, 2026 09:01

fdwr approved these changes

View reviewed changes

fdwr left a comment

Collaborator

👍

BruceDai added 10 commits

April 13, 2026 21:20


          rebase and fix conflict

c74be25


          correct minimum details for hardSigmoid/pad/scatterND/sigmoid ops

d2442c5


          add dfn refs

ed76aed


          updated for dequantizeLinear op to align with latest CL-7244911

aae49ff


          address Reilly's suggestions

e19a6dd


          address Reilly's comments

7ca68ed


          update index.bs to address Dwayne's some comments

b6294f0


          update index.bs to address Ningxin's comments

f2188b4


          update l2Pool2d and separate tables of listing input data types

d741ebd


          exclude int8/uint8 for input of gatherElements op

3f29bff

BruceDai force-pushed the minimum_datatype_rankrange branch from b6b300f to 3f29bff Compare

April 13, 2026 13:25


          update maximum allowed rank be 5 for prelu's input, slope and output

cda19db

mwyrzykowski approved these changes

View reviewed changes

mwyrzykowski left a comment

Conflict with the WG meeting, but ✅

BruceDai added 2 commits

May 9, 2026 17:43


          add limits data types and ranks for missed gruCell's hiddenState

98d93bd


          fix the limits tabe id for pow operator

38d2e10

fdwr approved these changes

View reviewed changes

fdwr left a comment

Collaborator

👍

huningxin reviewed

View reviewed changes

index.bs Outdated

index.bs Outdated

index.bs Outdated

index.bs


          remove DirectML backend to align with current Chromium implementations

961648d

BruceDai commented May 14, 2026 •

edited

Loading

Contributor Author

@BruceDai , what's your plan for fixing this issue? Generalizing them to 0 to 5D with backend reshapes sounds good to me.

@huningxin Thanks for your kindly reminder! Please review the fixing CL-7848774 .


          align logical op rank limits at 5

e1ed54a

BruceDai commented May 22, 2026

Contributor Author

Thanks @reillyeon @huningxin and @fdwr for reviewing and approving CL-7848774, now it has been landed.
Please take another review the new commit. Thanks! ☕


          update logical binary limits table to rank limits at 5

3f1465c

fdwr approved these changes

View reviewed changes

fdwr left a comment

Collaborator

👍 Thank you for enabling this.

huningxin reviewed

View reviewed changes

index.bs Outdated

index.bs Outdated

index.bs Outdated

BruceDai added 3 commits

June 11, 2026 14:15


          merge pow into the unified element-wise binary tensor limits table

ee63f34


          raise rank limit from 4 to 5 for the six comparison operators

7b8f326


          raise input rank limit from 4 to 5 for isNaN and isInfinite ops

8bf1fb2

BruceDai commented Jun 15, 2026

Contributor Author

@huningxin @fdwr Now those remaining issues are all resolved by landing CLs into Chromium. Please take another look, thanks!

fdwr approved these changes

View reviewed changes

fdwr left a comment

Collaborator

👍

huningxin approved these changes

View reviewed changes

huningxin left a comment

Contributor

LGTM, @BruceDai thanks for your relentless effort!

huningxin commented Jun 18, 2026

Contributor

I suppose this PR is ready to merge. Any further comments? @reillyeon and @anssiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet