Stop committing package-lock.json (#5) - #6
Merged
Merged
Conversation
Removes the committed package-lock.json and ignores it, matching the rest of the webship-js step-pack family. This repository's workflows do not use npm ci, so no CI change is needed. AI-Generated: Yes (lockfile removal and .gitignore entry; reviewed by Rajab Natshah.) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
actions/setup-node with cache: npm requires a lockfile and fails the job with "Dependencies lock file is not found" now that package-lock.json is no longer committed. AI-Generated: Yes (removed the setup-node cache option; reviewed by Rajab Natshah.) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the committed
package-lock.jsonand adds it to.gitignore, matching the rest ofthe webship-js step-pack family.
Closes #5
Test notes
npm ci, so removing the lockfile does not affect CI.AI-Generated: Yes (lockfile removal and .gitignore entry; reviewed by Rajab Natshah.)
Checkpoints
Automated unit/functional testing coverageDeveloper Documentation support on feature change/additionUser Guide Documentation support on feature change/additionAccessibility and Readability