Skip to content

Add edit action to routine list items #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charugupta-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add edit action to routine list items #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/features/routines/widgets/routines_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import 'package:wger/core/widgets/async_value_widget.dart';
import 'package:wger/core/widgets/confirm_delete_dialog.dart';
import 'package:wger/core/widgets/text_prompt.dart';
import 'package:wger/features/routines/providers/routines_notifier.dart';
import 'package:wger/features/routines/screens/routine_edit_screen.dart';
import 'package:wger/features/routines/screens/routine_screen.dart';
import 'package:wger/l10n/generated/app_localizations.dart';

Expand Down Expand Up @@ -98,6 +99,18 @@ class _RoutinesListState extends ConsumerState<RoutinesList> {
mainAxisSize: MainAxisSize.min,
children: [
if (!canOpen) const Icon(Icons.cloud_off),
IconButton(
icon: const Icon(Icons.edit),
tooltip: AppLocalizations.of(context).edit,
onPressed: canOpen
? () {
Navigator.of(context).pushNamed(
RoutineEditScreen.routeName,
arguments: routineId,
);
}
: null,
),
const VerticalDivider(),
if (_loadingRoutine == currentRoutine.id)
const IconButton(
Expand Down
26 changes: 26 additions & 0 deletions test/features/routines/screens/routine_list_screen_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import 'package:wger/core/form_screen.dart';
import 'package:wger/core/network/network_provider.dart';
import 'package:wger/features/routines/models/routine.dart';
import 'package:wger/features/routines/providers/routines_repository.dart';
import 'package:wger/features/routines/screens/routine_edit_screen.dart';
import 'package:wger/features/routines/screens/routine_list_screen.dart';
import 'package:wger/features/routines/screens/routine_screen.dart';
import 'package:wger/features/routines/widgets/forms/routine.dart';
Expand Down Expand Up @@ -80,6 +81,7 @@ void main() {
routes: {
FormScreen.routeName: (ctx) => const FormScreen(),
RoutineScreen.routeName: (ctx) => const RoutineScreen(),
RoutineEditScreen.routeName: (ctx) => const Scaffold(body: Text('Edit Routine Screen')),
},
),
);
Expand All @@ -96,6 +98,30 @@ void main() {
expect(find.text('test 2'), findsOneWidget);
expect(find.byType(Card), findsNWidgets(2));
expect(find.byType(ListTile), findsNWidgets(2));
expect(find.byIcon(Icons.edit), findsNWidgets(2));
expect(find.byIcon(Icons.delete), findsNWidgets(2));
});

testWidgets('Test the Edit button navigates to RoutineEditScreen', (WidgetTester tester) async {
await tester.pumpWidget(renderWidget());
await tester.pumpAndSettle();

await tester.tap(find.byIcon(Icons.edit).first);
await tester.pumpAndSettle();

expect(find.text('Edit Routine Screen'), findsOneWidget);
});

testWidgets('Edit button is disabled when offline and routine is not hydrated', (
WidgetTester tester,
) async {
await tester.pumpWidget(renderWidget(isOnline: false));
await tester.pumpAndSettle();

final editButton = tester.widget<IconButton>(
find.widgetWithIcon(IconButton, Icons.edit).first,
);
expect(editButton.onPressed, isNull);
});

testWidgets('Test deleting an item using the Delete button', (WidgetTester tester) async {
Expand Down