Skip to content

Fix exercise video play icon staying visible during playback #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandgeider merged 1 commit into from
Sep 7, 2026
Merged

Fix exercise video play icon staying visible during playback #1359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/features/exercises/widgets/videos.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,15 @@ class _ExerciseVideoWidgetState extends ConsumerState<ExerciseVideoWidget> {
alignment: Alignment.bottomCenter,
children: [
VideoPlayer(controller),
_ControlsOverlay(controller: controller),
// Rebuild the overlay whenever the controller notifies (it is a
// ValueNotifier). Reading controller.value.isPlaying does not
// subscribe to changes, so without this the play icon never
// disappears once playback starts.
ValueListenableBuilder<VideoPlayerValue>(
valueListenable: controller,
builder: (context, value, child) =>
_ControlsOverlay(controller: controller),
),
VideoProgressIndicator(controller, allowScrubbing: true),
],
),
Expand Down