Percent-encode caller-supplied path segments and refuse dot segments - #14
Open
robrigo wants to merge 6 commits into
Open
Percent-encode caller-supplied path segments and refuse dot segments#14robrigo wants to merge 6 commits into
robrigo wants to merge 6 commits into
Conversation
Every endpoint interpolated its NameType, UInt64Type, or string argument raw into the request path, so a value carrying a slash, a question mark, or a hash escaped its own segment and rewrote the request target, and a dot segment survived percent-encoding and was collapsed by the URL parser onto a sibling route of the same origin. One helper now encodes each segment where the path is assembled and throws on an empty, missing, or dot value, which is never an id or a name. The recorded fixtures replay unchanged, since every value they carry is already unreserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #12: the last commit is this change, the five before it are #12. Rebases cleanly once #12 merges.
Why
Every endpoint interpolates its
NameType,UInt64Type, or string argument raw into the request path. A value carrying/,?, or#escapes its own segment and rewrites the request target, and a.or..segment survives percent-encoding and is collapsed by the URL parser onto a sibling route of the same origin, so an application that passes a user-controlled string intoget_collectionorget_royalty_configlets that user choose the route. One helper,pathSegmentinsrc/endpoints/utils.ts, now encodes each of the 52 segments where the path is assembled and throws on an empty, missing, or dot value, which is never an id or a name. Dotted Antelope names such asalien.worldspass unchanged. The helper is not part of the public API.Tests
make checkandmake testpass at 256 tests. All 95 recorded fixtures replay unchanged, since every value they carry is already unreserved, which also shows the paths are byte-identical for real ids and names.test/utils.tscovers the encoding, theNameandUInt64coercions, the rejections, and aget_asset('..')call rejecting before any fetch.