Repository navigation
test: run the Windows hook canary check in the native hook integration module - #227
Merged
Merged
Conversation
…n module Remote baseline: origin/main @ 8a62288 Scope: The unit test that proves the packaged cmd wrapper ignores same-named programs placed in the workspace read a pre-v0.17.0 path and was skipped everywhere except Windows, where no CI job ran its module, so it had never executed. The check now lives in tests/hook_runtime_integration.py, which the cross-platform workflow runs natively on Windows, and reuses that module's exact-command invocation and fixtures. The unit module keeps the structural hook policy tests. Repository policy revision 114 records the change for Issue #216 with an unchanged plugin version and runtime digest. Validation: python3 -B scripts/check-publication.py: passed on the exact tree (153 required files, 30 immutable action pins) python3 -B -m unittest discover -s tests -p 'test_*.py': 311 tests OK in a disposable clone of the tree python -B -m unittest tests.hook_runtime_integration -v: 6 tests OK on Linux; the Windows canary test skipped as designed git diff --check: clean; ASCII scan of the changed Markdown, JSON, and Python files: passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #216. The only test that proves the packaged Windows
cmdwrapper does not execute same-named programs from the workspace readskills/using-axiom/SKILL.md, a path that stopped existing when the plugin moved underplugin/in v0.17.0. The test was skipped off Windows, and the Windows CI job never ran its module, so the check had never executed. It now lives intests/hook_runtime_integration.py, which the cross-platform workflow already runs natively on Windows, and reuses that module's exact-command invocation, spaced plugin-root fixture, and byte comparisons. The unit moduletests/test_hooks.pykeeps the structural hook policy tests. This is the smallest change that makes the check run: no workflow or workflow-contract edit is needed.Repository policy revision 114 records the change; the plugin version and runtime contract digest are unchanged.
Affected files and surfaces
tests/hook_runtime_integration.py(new native Windows canary test);tests/test_hooks.py(stale test and its imports removed);CHANGELOG.md,evidence/repository-policy-revisions-v1.json,evidence/runtime-identity.json,evidence/release-status.json,docs/runtime-identity.md(revision 114)Routing and authorization impact
Documentation
No documentation describes the moved test; the changelog entry records the move. Installation and hook commands are unchanged.
Validation
python3 -B scripts/check-publication.pypython3 -B -m unittest discover -s tests -p 'test_*.py'git diff --checkpython -B -m unittest tests.hook_runtime_integration -von Linux: 6 tests OK, the new Windows canary test skipped as designed; thehook-runtime-windows-2025check on this pull request is the first execution of that test. ASCII scan of the changed Markdown, JSON, and Python files: passed.Cross-platform parity
Unrelated work