Skip to content

test: run the Windows hook canary check in the native hook integration module - #227

Merged
wheakerd merged 1 commit into
mainfrom
feature/windows-hook-canary-test
Oct 30, 2026
Merged

wheakerd merged 1 commit into
mainfrom
feature/windows-hook-canary-test

Conversation

@wheakerd

Copy link
Copy Markdown
Owner

Scope

Refs #216. The only test that proves the packaged Windows cmd wrapper does not execute same-named programs from the workspace read skills/using-axiom/SKILL.md, a path that stopped existing when the plugin moved under plugin/ in v0.17.0. The test was skipped off Windows, and the Windows CI job never ran its module, so the check had never executed. It now lives in tests/hook_runtime_integration.py, which the cross-platform workflow already runs natively on Windows, and reuses that module's exact-command invocation, spaced plugin-root fixture, and byte comparisons. The unit module tests/test_hooks.py keeps the structural hook policy tests. This is the smallest change that makes the check run: no workflow or workflow-contract edit is needed.

Repository policy revision 114 records the change; the plugin version and runtime contract digest are unchanged.

Affected files and surfaces

  • Shared files: None
  • Codex-specific files: None
  • Claude Code-specific files: None
  • Documentation or validation files: tests/hook_runtime_integration.py (new native Windows canary test); tests/test_hooks.py (stale test and its imports removed); CHANGELOG.md, evidence/repository-policy-revisions-v1.json, evidence/runtime-identity.json, evidence/release-status.json, docs/runtime-identity.md (revision 114)

Routing and authorization impact

  • Route-selection impact: None.
  • Action-authorization impact: None.
  • New or changed stop conditions: None.

Documentation

No documentation describes the moved test; the changelog entry records the move. Installation and hook commands are unchanged.

Validation

Command Result
python3 -B scripts/check-publication.py Passed on this exact tree: 153 required files, 168 Markdown files, 96 offline route contract fixtures, 30 immutable external action and image pins
python3 -B -m unittest discover -s tests -p 'test_*.py' OK in a disposable clone of this tree: 311 tests (one test moved out of the discovered set)
git diff --check Passed
Additional targeted checks python -B -m unittest tests.hook_runtime_integration -v on Linux: 6 tests OK, the new Windows canary test skipped as designed; the hook-runtime-windows-2025 check on this pull request is the first execution of that test. ASCII scan of the changed Markdown, JSON, and Python files: passed.

Cross-platform parity

  • Shared skill changes were reviewed against Codex and Claude Code, or this change does not affect shared skills.
  • Manifest, marketplace, and hook differences remain intentional and documented.
  • Optional host-native validation results include the host/tool version, or are marked unavailable.

Unrelated work

  • I reviewed the final diff and did not reset, hide, stage, or rewrite unrelated work.
  • I did not add generated caches, disposable validation copies, local maintenance notes, or tool output.
  • I called out every affected file and any routing, authorization, documentation, or parity impact above.

…n module

Remote baseline: origin/main @ 8a62288

Scope:
The unit test that proves the packaged cmd wrapper ignores same-named programs placed in the workspace read a pre-v0.17.0 path and was skipped everywhere except Windows, where no CI job ran its module, so it had never executed. The check now lives in tests/hook_runtime_integration.py, which the cross-platform workflow runs natively on Windows, and reuses that module's exact-command invocation and fixtures. The unit module keeps the structural hook policy tests. Repository policy revision 114 records the change for Issue #216 with an unchanged plugin version and runtime digest.

Validation:
python3 -B scripts/check-publication.py: passed on the exact tree (153 required files, 30 immutable action pins)
python3 -B -m unittest discover -s tests -p 'test_*.py': 311 tests OK in a disposable clone of the tree
python -B -m unittest tests.hook_runtime_integration -v: 6 tests OK on Linux; the Windows canary test skipped as designed
git diff --check: clean; ASCII scan of the changed Markdown, JSON, and Python files: passed
@wheakerd
wheakerd merged commit ad19af1 into main Oct 30, 2026
10 checks passed
@wheakerd
wheakerd deleted the feature/windows-hook-canary-test branch October 30, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant