Skip to content

Buttons: Size Forgejo's native form buttons from one list #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whereareiam merged 1 commit into from
Oct 4, 2026
Merged

Buttons: Size Forgejo's native form buttons from one list #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions components/common/button/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,22 @@
outline: 2px solid var(--github-fgColor-accent);
outline-offset: 2px;
}

/*
* Native controls: Forgejo's own buttons that cannot take the theme-control class get the same
* 32px control size here. To size another native button, add it to the list.
*/
:is(
.review-box-panel form > .ui.ui.ui.button,
.comment-code-cloud .field.footer .ui.ui.ui.button,
.comment-code-cloud :is(.button-row, .button-sequence):has(.comment-form-reply) .ui.ui.ui.button,
.page-content.repository.new.issue.github-issue-new .issue-content-left .text.right .ui.ui.ui.button,
.page-content.repository.new.release .ui.form .ui.ui.ui.button:not(.mini)
) {
height: 32px;
min-height: 32px;
padding: 5px 12px;
font-size: 14px;
font-weight: 500;
line-height: 20px;
}
8 changes: 0 additions & 8 deletions styles/components/issues/issue_new.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,6 @@ export default css`
& .combo-markdown-editor textarea {
min-height: 300px !important;
}
& .issue-content-left .text.right .ui.ui.ui.button {
height: 32px;
min-height: 32px;
padding: 5px 12px;
font-size: 14px;
font-weight: 500;
line-height: 20px;
}
/* Sidebar: muted bold headings with the gear at the right edge, as on an issue page. */
& .issue-content-right.ui.segment {
padding: 0;
Expand Down
17 changes: 3 additions & 14 deletions styles/components/issues/pull_files_review.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,5 @@
import { css, otherThemeVars, themeVars } from "@lutinglt/gitea-github-theme/core";

/** Buttons that close a review form, at GitHub's 32px control height. */
const reviewButton = `
height: 32px;
min-height: 32px;
margin: 0;
padding: 5px 12px;
font-size: 14px;
font-weight: 500;
line-height: 20px;
`;

export default css`
/* "Finish review" opens Forgejo's form in a popup; GitHub shows it as a 640px dialog. */
.tippy-box[data-theme="menu"]:has(.review-box-panel) {
Expand Down Expand Up @@ -98,7 +87,7 @@ export default css`
border-color: ${themeVars.color.light.border};
}
& form > .ui.ui.ui.button {
${reviewButton}
/* Sized by the native control list in the button component. */
margin: 16px 0;
}
& form > .ui.ui.ui.button:last-of-type {
Expand Down Expand Up @@ -137,15 +126,15 @@ export default css`
gap: 8px;
}
& .ui.ui.ui.button {
${reviewButton}
margin: 0;
}
}
/* The row under a posted conversation, in the diff and on the Conversation tab: Previous / Next, Resolve, Reply */
& :is(.button-row, .button-sequence):has(.comment-form-reply) {
gap: 8px;
margin-top: 8px;
& .ui.ui.ui.button {
${reviewButton}
margin: 0;
display: inline-flex;
align-items: center;
gap: 8px;
Expand Down
8 changes: 0 additions & 8 deletions styles/pages/releases.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,14 +720,6 @@ body:has(.page-content.repository.new.release) .repository-content-header {
padding: 0;
border: 0;
}
.ui.form .ui.ui.ui.button:not(.mini) {
height: 32px;
min-height: 32px;
padding: 5px 12px;
font-size: 14px;
font-weight: 500;
line-height: 20px;
}
.ui.form .ui.ui.ui.mini.button {
height: 28px;
min-height: 28px;
Expand Down
Loading