Skip to content

Fix docs CI build and setuptools #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillermoaguilar merged 4 commits into from
Sep 13, 2026
Merged

Fix docs CI build and setuptools #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cac910
Fix docs requirements file so pip reads it
guillermoaguilar Sep 12, 2026
c6452d4
Pin jupyter-book below 2.0 for the docs build
guillermoaguilar Sep 12, 2026
c59aef9
Restrict setuptools package discovery to psignifit
guillermoaguilar Sep 12, 2026
851cce5
Remove unused imports from package __init__
guillermoaguilar Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/build-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ jobs:
- name: Install psignifit
run: pip install .

- name: Install jupyter_book
shell: bash -l {0}
run: pip install -U git+https://github.com/ExecutableBookProject/jupyter-book.git@main

- name: Build My Book
shell: bash -l {0}
run: jupyter-book build --warningiserror docs/
10 changes: 5 additions & 5 deletions docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
- sphinx
- numpy
- matplotlib
- sphinxcontrib-mermaid
- jupyter-book
sphinx
numpy
matplotlib
sphinxcontrib-mermaid
jupyter-book>=1.0,<2
3 changes: 0 additions & 3 deletions psignifit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
Python psignifit - based on Matlab psignifit by Heiko Schütt with help from
Felix Wichmann, Jakob Macke and Stefan Harmeling.
"""
import os
import subprocess

# import here the main function
from .psignifit import psignifit
from .tools import pool_blocks
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,13 @@ docs = [
"sphinx-gallery",
"sphinx_rtd_theme",
"matplotlib",
"jupyter-book==0.14",
"jupyter-book>=1.0,<2",
"jupytext>=1.13.3",
"jupyterlab_myst",
"myst_nb",
"ipywidgets",
"sphinx-hoverxref",
]

[tool.setuptools.packages.find]
include = ["psignifit*"]
Loading