Repository navigation
fix: pin prettier as a local hook so autoupdate can't propose alpha bumps - #202
Merged
Merged
Conversation
…umps pre-commit.ci's autoupdate always jumps to the highest available tag on the mirrors-prettier repo, which only has v4 alpha pre-releases past v3.1.0 since prettier hasn't cut a stable v4 yet. This has repeatedly produced broken autoupdate PRs (#168, #188, #192, #200). Converting the hook to a local, npm-pinned hook removes it from autoupdate's scope entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mirrors-prettierrepo, which only has v4 alpha pre-releases past v3.1.0 (prettier hasn't cut a stable v4 yet). This has repeatedly produced broken autoupdate PRs proposing av4.0.0-alpha.xbump (chore: bump pre-commit hook versions (pre-commit-hooks, mypy, markdownlint, ruff) #168, [pre-commit.ci] pre-commit autoupdate #188, [pre-commit.ci] pre-commit autoupdate #192, [pre-commit.ci] pre-commit autoupdate #200), requiring a manual revert each time.repo: localhook, npm-pinned toprettier@3.1.0directly instead of tracked via the mirror's git tags. A local hook has norevfor autoupdate to touch, so this stops the recurring bad-bump PRs at the source rather than reverting them each time they appear.pre-commit run prettier --all-filesproduces zero diffs on the current tree (same prettier version, same args), and the fullpre-commit run --all-filessuite passes.Test plan
pre-commit run prettier --all-files- passes, no formatting diffs vs. the previous mirror-based hookpre-commit run --all-files(full suite) - all hooks pass