Repository navigation
Encrypt dumps with age when AGE_RECIPIENT is set (CLOUD-755) - #5
Merged
Merged
Conversation
pg_dump output is piped straight into age, so the dump never lands on disk unencrypted, and the object gets the .dump.age extension. Without AGE_RECIPIENT the image behaves as before. The shellcheck directive moves under the shebang so it covers the whole file and make lint passes again.
vdromanov
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что происходит; кому и зачем нужно:
CLOUD-755: дампы в S3 лежали открытыми, а в дампе Grafana есть секреты, зашифрованные её ключом по умолчанию. Если задан
AGE_RECIPIENT(открытый ключ age), выводpg_dumpсразу шифруется и уходит в S3 как.dump.age, на диск открытый дамп не попадает. Директива shellcheck перенесена под shebang,make lintснова проходит. Порядок раскатки описан в PR wirenboard/cloud-infrastructure.Что поменялось для пользователей:
Без
AGE_RECIPIENTничего. Как расшифровать дамп, написано в README.Как проверял/а:
Собранный образ против MinIO и PostgreSQL 15: дамп с ключом расшифровывается и восстанавливается через
pg_restore, без ключа выгружается обычный.dump, битый ключ и упавшийpg_dumpзавершаются с кодом 1 без выгрузки и вебхука. Чистка старых дампов не трогает чужие префиксы, в том числе парыstagingиstaging2.