You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tests: cover more RuleLogic edge cases (SSID, time window, day mask) #23
I'd like to take this one too. I'll extend RuleLogicTest.kt with the SSID, time-window, day-mask, and battery edge cases, run ./gradlew testStableDebugUnitTest, and open a separate PR against beta so each issue stays small.
PR #25 merged into beta on 2026-11-13: RuleLogicTest.kt now covers the SSID, time-window, day-mask and battery edge cases listed above, ./gradlew testStableDebugUnitTest passes with 32 tests, and no production bug surfaced. The Closes #23 line did not auto-close this issue because the PR targets beta rather than the default branch main. Could a maintainer close it? I only have read access on the repo.
Activity
anubhavaanand commentedon Nov 11, 2026
I'd like to take this one too. I'll extend
RuleLogicTest.ktwith the SSID, time-window, day-mask, and battery edge cases, run./gradlew testStableDebugUnitTest, and open a separate PR againstbetaso each issue stays small.anubhavaanand commentedon Nov 14, 2026
PR #25 merged into beta on 2026-11-13: RuleLogicTest.kt now covers the SSID, time-window, day-mask and battery edge cases listed above, ./gradlew testStableDebugUnitTest passes with 32 tests, and no production bug surfaced. The Closes #23 line did not auto-close this issue because the PR targets beta rather than the default branch main. Could a maintainer close it? I only have read access on the repo.